Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-session')
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jeena
	Mar 15 2022, 8:55 PM

Description

Error

mwversion: 1.38.0-wmf.26
reqId: 0104a343-684a-41d7-854d-ee5166c5142a
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-session')

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactory.php(829)
#0 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactory.php(291): Wikimedia\Rdbms\LBFactory->assertTransactionRoundStage(string)
#1 /srv/mediawiki/php-1.38.0-wmf.26/includes/MediaWiki.php(678): Wikimedia\Rdbms\LBFactory->commitPrimaryChanges(string, array)
#2 /srv/mediawiki/php-1.38.0-wmf.26/includes/api/ApiMain.php(896): MediaWiki::preOutputCommit(DerivativeContext)
#3 /srv/mediawiki/php-1.38.0-wmf.26/includes/api/ApiMain.php(841): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.38.0-wmf.26/api.php(90): ApiMain->execute()
#5 /srv/mediawiki/php-1.38.0-wmf.26/api.php(45): wfApiMain()
#6 /srv/mediawiki/w/api.php(3): require(string)
#7 {main}

Impact

Train rolled to group0, 24 errors in the last 30 min

Notes

Details

Request URL: https://test.wikipedia.org/w/api.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	rdbms: fix owner id and RELEASE_ALL_LOCKS query in session flushing methods	mediawiki/core	wmf/1.38.0-wmf.26	+22 -8
	rdbms: fix owner id and RELEASE_ALL_LOCKS query in session flushing methods	mediawiki/core	master	+22 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T300202 1.38.0-wmf.26 deployment blockers
		Duplicate	PRODUCTION ERROR	Ladsgroup	T303887 Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-session')

Event Timeline

jeena created this task.Mar 15 2022, 8:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2022, 8:55 PM

Related to T303885 ?

jeena added a parent task: T300202: 1.38.0-wmf.26 deployment blockers.Mar 15 2022, 8:57 PM

Caused by the same thing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/737824/

I'm inclined to revert that patch and follow ups

I've told the author of that patch before and this is not the first time. Making really large patches like this, in critical part of infrastructure is bound to break. Specially when a patch that supposed to do one thing has a dedicated section in commit message with "Also" and then doing at least eight more things on top. These type of patches are a recipe for disaster and easily can cause data corruption.

In T303887#7779707, @Ladsgroup wrote:

Caused by the same thing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/737824/

I'm inclined to revert that patch and follow ups

There is a patch for review to fix this I think: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/770935/, but revert could also be done.

I suggest deploying that fix, if that fixes everything and no more errors, sure. If we find more errors, then I revert the whole chain.

Zabe subscribed.Mar 15 2022, 9:15 PM

Change 771081 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: use the LoadBalancer id in flushPrimarySessions()

https://gerrit.wikimedia.org/r/771081

gerritbot added a project: Patch-For-Review.Mar 16 2022, 2:54 AM

jeena triaged this task as Unbreak Now! priority.Mar 16 2022, 5:12 PM

aaron mentioned this in T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks').Mar 16 2022, 5:38 PM

aaron merged a task: T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks').Mar 16 2022, 5:44 PM

aaron added subscribers: • LarsWirzenius, • nnikkhoui, Krinkle, RhinosF1.

Change 771081 merged by jenkins-bot:

[mediawiki/core@master] rdbms: fix owner id and RELEASE_ALL_LOCKS query in session flushing methods

https://gerrit.wikimedia.org/r/771081

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 4:10 AM

Change 770938 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@wmf/1.38.0-wmf.26] rdbms: fix owner id and RELEASE_ALL_LOCKS query in session flushing methods

https://gerrit.wikimedia.org/r/770938

gerritbot added a project: Patch-For-Review.Mar 17 2022, 5:35 PM

Reverted the whole thing. Please do not re-apply the patch without major rethinking of how it should be done and how it should be deployed. I try to find a place to write an essay about this.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 17 2022, 9:06 PM

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Mar 17 2022, 9:15 PM

Change 770938 abandoned by Aaron Schulz:

[mediawiki/core@wmf/1.38.0-wmf.26] rdbms: fix owner id and RELEASE_ALL_LOCKS query in session flushing methods

Reason:

https://gerrit.wikimedia.org/r/770938

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 10:10 PM

Krinkle closed this task as a duplicate of T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks').Mar 18 2022, 1:20 PM

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 23 2022, 6:54 PM

Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-session')Closed, DuplicatePublicPRODUCTION ERRORActions