Page MenuHomePhabricator
Create Task
Maniphest T303991

Design QA on testwiki
Closed, ResolvedPublic
Actions

Assigned To
TheresNoTime
Authored By
• NRodriguez
Mar 16 2022, 6:07 PM
Tags
Referenced Files
F35105647: Screen Shot 2022-05-05 at 22.08.26.png
May 6 2022, 5:23 AM
F35105641: Screen Shot 2022-05-05 at 22.07.06.png
May 6 2022, 5:23 AM
F35047518: Screen Shot 2022-04-11 at 16.33.22.png
Apr 11 2022, 11:37 PM
F35047520: Screen Shot 2022-04-11 at 16.33.30.png
Apr 11 2022, 11:37 PM
F35047508: Screen Shot 2022-04-11 at 16.30.22.png
Apr 11 2022, 11:32 PM
F35047511: Screen Shot 2022-04-11 at 16.31.46.png
Apr 11 2022, 11:32 PM
F35047500: Screen Shot 2022-04-11 at 16.23.24.png
Apr 11 2022, 11:28 PM
Subscribers
Aklapper
nayoub
• NRodriguez
Samwilson
TheresNoTime

Description

Design QA checklist before first beta release, in progress.

StatusStateUIBlocking
⚠️Hover (default) – background: Base80
Screen Shot 2022-04-11 at 16.30.22.png (878×1 px, 50 KB)
True
⚠️Active – label should be blue as well
Screen Shot 2022-04-11 at 16.31.46.png (688×772 px, 138 KB)
True
⚠️Hover (while active) – background: Base80
Screen Shot 2022-04-11 at 16.23.24.png (884×1 px, 167 KB)
True

ii. Resize UI To be worked on T307105: Improvements to resize UI

StatusStateCurrent UINew UIBlocking
⚠️Add a minimal resize limit on the preview pane to 248px
Screen Shot 2022-04-11 at 16.33.30.png (1×1 px, 365 KB)
Screen Shot 2022-04-11 at 16.33.22.png (1×1 px, 527 KB)
False
⚠️Visual adjustments on handlebars, details below*
Screen Shot 2022-05-05 at 22.07.06.png (1×906 px, 232 KB)
Screen Shot 2022-05-05 at 22.08.26.png (1×878 px, 327 KB)
False

*Visual adjustments on handlebars, details
both drag elements should be 52px long, keeping the same width as now.
Margin: 2px; Background on the split panes one: OOUI Base 90 #F8F9FA

ii. Loading state

  • The loading bar ("blue snake") should stay on top of the preview pane. Currently, it disappears when users scroll.

Details

SubjectRepoBranchLines +/-
Realtime preview: improve toolbar button stylemediawiki/extensions/WikiEditormaster+34 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• NRodriguez created this task.Mar 16 2022, 6:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 6:07 PM
• NRodriguez mentioned this in T303961: Rollout plan for real-time preview.Mar 16 2022, 6:08 PM
• NRodriguez renamed this task from Design QA on patchdemo to Design QA on testwiki.Mar 21 2022, 2:46 PM
• NRodriguez added a project: Community-Tech (CommTech-Sprint-23).Apr 7 2022, 5:43 PM
nayoub updated the task description. (Show Details)Apr 8 2022, 6:37 PM
nayoub updated the task description. (Show Details)
nayoub updated the task description. (Show Details)Apr 8 2022, 6:39 PM
nayoub updated the task description. (Show Details)Apr 11 2022, 11:28 PM
nayoub updated the task description. (Show Details)Apr 11 2022, 11:32 PM
nayoub updated the task description. (Show Details)Apr 11 2022, 11:37 PM
nayoub updated the task description. (Show Details)Apr 13 2022, 6:08 PM
gerritbot added a comment.Apr 19 2022, 7:09 AM

Change 784084 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime preview: improve toolbar button style

https://gerrit.wikimedia.org/r/784084

gerritbot added a project: Patch-For-Review.Apr 19 2022, 7:09 AM
Samwilson subscribed.Apr 19 2022, 9:48 AM

i. Preview button in the Editor toolbar

@nayoub Do these colors/hover etc. only apply to Vector skin? There's already a hover outline in Monobook for instance. Actually, it might be best to do it for all skins except MonoBook.

The loading bar ("blue snake") should stay on top of the preview pane. Currently, it disappears when users scroll.

This was done as part of T304568.

Samwilson updated the task description. (Show Details)Apr 19 2022, 9:49 AM
TheresNoTime subscribed.Apr 19 2022, 10:00 AM
TheresNoTime claimed this task.Apr 19 2022, 11:15 AM
nayoub added a comment.Apr 19 2022, 6:47 PM

Do these colors/hover etc. only apply to Vector skin? There's already a hover outline in Monobook for instance. Actually, it might be best to do it for all skins except MonoBook.

@Samwilson Yes they apply to all vector skin (both current and new) but we can use it for the other skins as well if you think it's appropriate :)

dmaza moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-23) board.Apr 20 2022, 2:47 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-24); removed Community-Tech (CommTech-Sprint-23).Apr 25 2022, 4:57 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.Apr 25 2022, 5:02 PM
dmaza added a subtask: T307105: Improvements to resize UI.Apr 28 2022, 1:55 PM
dmaza updated the task description. (Show Details)
dmaza added a subtask: T307106: Improve preview button look and feel in the Editor toolbar.Apr 28 2022, 1:58 PM
dmaza updated the task description. (Show Details)
gerritbot added a comment.May 4 2022, 11:31 AM

Change 784084 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: improve toolbar button style

https://gerrit.wikimedia.org/r/784084

TheresNoTime closed subtask T307106: Improve preview button look and feel in the Editor toolbar as Resolved.May 4 2022, 11:37 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 4 2022, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 4 2022, 12:30 PM
Samwilson reopened subtask T307106: Improve preview button look and feel in the Editor toolbar as Open.May 4 2022, 11:47 PM

@nayoub don't forget to create a task for "Visual adjustments on handlebars". I think that's the last part of this ticket (the other bits now have their own tasks, for easier tracking).

nayoub added a comment.May 6 2022, 5:17 AM

Thanks @Samwilson, I added a description and visual references for "Visual adjustments on handlebars" on T307105

nayoub updated the task description. (Show Details)May 6 2022, 5:23 AM
TheresNoTime moved this task from In Development 💻 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-24) board.May 18 2022, 2:28 PM
• NRodriguez closed this task as Resolved.May 19 2022, 2:14 PM
• NRodriguez closed subtask T307105: Improvements to resize UI as Resolved.
• NRodriguez closed subtask T307106: Improve preview button look and feel in the Editor toolbar as Resolved.
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-24) board.May 24 2022, 6:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL