Page MenuHomePhabricator

Design QA on testwiki
Closed, ResolvedPublic

Description

Design QA checklist before first beta release, in progress.

StatusStateUIBlocking
⚠️Hover (default) – background: Base80
Screen Shot 2022-04-11 at 16.30.22.png (878Γ—1 px, 50 KB)
True
⚠️Active – label should be blue as well
Screen Shot 2022-04-11 at 16.31.46.png (688Γ—772 px, 138 KB)
True
⚠️Hover (while active) – background: Base80
Screen Shot 2022-04-11 at 16.23.24.png (884Γ—1 px, 167 KB)
True

ii. Resize UI To be worked on T307105: Improvements to resize UI

StatusStateCurrent UINew UIBlocking
⚠️Add a minimal resize limit on the preview pane to 248px
Screen Shot 2022-04-11 at 16.33.30.png (1Γ—1 px, 365 KB)
Screen Shot 2022-04-11 at 16.33.22.png (1Γ—1 px, 527 KB)
False
⚠️Visual adjustments on handlebars, details below*
Screen Shot 2022-05-05 at 22.07.06.png (1Γ—906 px, 232 KB)
Screen Shot 2022-05-05 at 22.08.26.png (1Γ—878 px, 327 KB)
False

*Visual adjustments on handlebars, details
both drag elements should be 52px long, keeping the same width as now.
Margin: 2px; Background on the split panes one: OOUI Base 90 #F8F9FA

ii. Loading state

  • The loading bar ("blue snake") should stay on top of the preview pane. Currently, it disappears when users scroll.

Event Timeline

NRodriguez renamed this task from Design QA on patchdemo to Design QA on testwiki.Mar 21 2022, 2:46 PM
nayoub updated the task description. (Show Details)

Change 784084 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime preview: improve toolbar button style

https://gerrit.wikimedia.org/r/784084

i. Preview button in the Editor toolbar

@nayoub Do these colors/hover etc. only apply to Vector skin? There's already a hover outline in Monobook for instance. Actually, it might be best to do it for all skins except MonoBook.

The loading bar ("blue snake") should stay on top of the preview pane. Currently, it disappears when users scroll.

This was done as part of T304568.

Do these colors/hover etc. only apply to Vector skin? There's already a hover outline in Monobook for instance. Actually, it might be best to do it for all skins except MonoBook.

@Samwilson Yes they apply to all vector skin (both current and new) but we can use it for the other skins as well if you think it's appropriate :)

Change 784084 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: improve toolbar button style

https://gerrit.wikimedia.org/r/784084

@nayoub don't forget to create a task for "Visual adjustments on handlebars". I think that's the last part of this ticket (the other bits now have their own tasks, for easier tracking).

Thanks @Samwilson, I added a description and visual references for "Visual adjustments on handlebars" on T307105