| dmaza | |
| Apr 28 2022, 1:55 PM |
| F35105641: Screen Shot 2022-05-05 at 22.07.06.png | |
| May 6 2022, 5:15 AM |
| F35105647: Screen Shot 2022-05-05 at 22.08.26.png | |
| May 6 2022, 5:15 AM |
| F35102028: 3ZHdBTb0tO.gif | |
| May 4 2022, 12:01 PM |
| F35047520: Screen Shot 2022-04-11 at 16.33.30.png | |
| Apr 28 2022, 1:55 PM |
| F35047518: Screen Shot 2022-04-11 at 16.33.22.png | |
| Apr 28 2022, 1:55 PM |
| Status | State | Current UI | New UI | Blocking |
| ⚠️ | Add a minimal resize limit on the preview pane to 248px |  |  | False |
| ⚠️ | Visual adjustments on handlebars, details below* |  |  | False |
*Visual adjustments on handlebars, details
both drag elements should be 52px long, keeping the same width as now.
Margin: 2px; Background on the split panes one: OOUI Base 90 #F8F9FA
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | TheresNoTime | T303991 Design QA on testwiki | |||
| Resolved | TheresNoTime | T307105 Improvements to resize UI |
Change 788713 had a related patch set uploaded (by Samtar; author: Samtar):
[mediawiki/extensions/WikiEditor@master] Realtime preview: set minimal resize limit
My current implementation of this introduces the following behaviour:
which @Majavah kindly pointed out is not entirely expected.
Edit: This actually seems to be the behaviour of resizing these panes in general, and was not introduced by my changes
Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/030f6e1c8e/w/
Test wiki on Patch demo by TheresNoTime using patch(es) linked to this task was deleted:
Change 788713 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Realtime preview: set minimal resize limit
Change 790673 had a related patch set uploaded (by Samtar; author: Samtar):
[mediawiki/extensions/WikiEditor@master] Realtime preview: Visual adjustments on handlebars
Change 790673 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Realtime preview: Visual adjustments on handlebars
This looks fine to me. I tested on different skins and on Firefox, Chromium and Safari.
Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (5f7581d) 06:25, 16 May 2022.