Page MenuHomePhabricator
Create Task
Maniphest T304002

Some mediawiki pages showing duplicate login + unstyled login status in user menu
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
cjming
Mar 16 2022, 7:32 PM
Tags
Referenced Files
F35010332: Screen Shot 2022-03-17 at 1.21.12 PM.png
Mar 17 2022, 8:21 PM
F35009356: Screen Shot 2022-03-16 at 4.33.27 PM.png
Mar 16 2022, 11:33 PM
F35009317: Screen Shot 2022-03-16 at 3.37.14 PM.png
Mar 16 2022, 10:37 PM
F35009131: Screen Shot 2022-03-16 at 8.52.01 PM.png
Mar 16 2022, 7:52 PM
F35009117: Screen Shot 2022-03-16 at 1.28.54 PM.png
Mar 16 2022, 7:33 PM
Subscribers
Aklapper
cjming
Jdlrobson
ovasileva

Description

On mediawiki, some pages show duplicate login button plus off-styled login-status for anonymous users.

i.e. short list of affected pages:
https://www.mediawiki.org/wiki/Phabricator
https://www.mediawiki.org/wiki/Reading/Web/Chores
https://www.mediawiki.org/wiki/Project:Support_desk
https://www.mediawiki.org/wiki/Project:Help
https://www.mediawiki.org/wiki/Development_statistics

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • Duplicate logins shown
  • "Not logged in" status not styled like the other items in the menu

What should have happened instead?:

  • 2nd login should not be there
  • "Not logged in" should not be there?

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Screen Shot 2022-03-16 at 1.28.54 PM.png (1×2 px, 608 KB)

Details

SubjectRepoBranchLines +/-
Fix updateUserLinksDropdownItems not being calledmediawiki/skins/Vectorwmf/1.38.0-wmf.26+7 -5
Fix updateUserLinksDropdownItems not being calledmediawiki/skins/Vectormaster+7 -5
Revert "Refactor user links functions in Hooks.php to increase test coverage"mediawiki/skins/Vectormaster+67 -131
Fix duplicate login + unstyled login status bug in anon user menumediawiki/skins/Vectormaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

cjming created this task.Mar 16 2022, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 7:32 PM
cjming updated the task description. (Show Details)Mar 16 2022, 7:33 PM
ovasileva triaged this task as High priority.Mar 16 2022, 7:48 PM
ovasileva subscribed.
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Mar 16 2022, 7:51 PM

Can also reproduce on testwiki (https://test.wikipedia.org/wiki/Main_Page)

Screen Shot 2022-03-16 at 8.52.01 PM.png (310×1 px, 137 KB)

ovasileva raised the priority of this task from High to Unbreak Now!.Mar 16 2022, 7:54 PM
ovasileva added a project: Platform Engineering.
Jdlrobson mentioned this in T300202: 1.38.0-wmf.26 deployment blockers.Mar 16 2022, 7:56 PM
Jdlrobson added a parent task: T300202: 1.38.0-wmf.26 deployment blockers.
gerritbot added a comment.Mar 16 2022, 8:36 PM

Change 771452 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix duplicate login + unstyled login status bug in anon user menu

https://gerrit.wikimedia.org/r/771452

gerritbot added a project: Patch-For-Review.Mar 16 2022, 8:36 PM
• nray removed a project: Platform Engineering.Mar 16 2022, 8:39 PM
gerritbot added a comment.Mar 16 2022, 9:05 PM

Change 771452 abandoned by Nray:

[mediawiki/skins/Vector@master] Fix duplicate login + unstyled login status bug in anon user menu

Reason:

See Idc9cd3a324f48d2c48243b5011d1559839789539 which includes an isset check

https://gerrit.wikimedia.org/r/771452

gerritbot added a comment.Mar 16 2022, 9:08 PM

Change 771458 had a related patch set uploaded (by Nray; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix updateUserLinksDropdownItems not being called

https://gerrit.wikimedia.org/r/771458

gerritbot added a comment.Mar 16 2022, 9:20 PM

Change 771391 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Revert "Refactor user links functions in Hooks.php to increase test coverage"

https://gerrit.wikimedia.org/r/771391

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 16 2022, 9:42 PM
gerritbot added a comment.Mar 16 2022, 10:35 PM

Change 771395 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.26] Fix updateUserLinksDropdownItems not being called

https://gerrit.wikimedia.org/r/771395

gerritbot added a comment.Mar 16 2022, 10:35 PM

Change 771391 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Revert "Refactor user links functions in Hooks.php to increase test coverage"

Reason:

Using https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/771458

https://gerrit.wikimedia.org/r/771391

Jdlrobson added a project: Vector (legacy skin).Mar 16 2022, 10:37 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson subscribed.

Fixed locally. Can replicate on beta cluster when in an incognito mode, we can backport this change when we've confirmed it's fixed there:

Screen Shot 2022-03-16 at 3.37.14 PM.png (920×1 px, 153 KB)

gerritbot added a comment.Mar 16 2022, 11:17 PM

Change 771458 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix updateUserLinksDropdownItems not being called

https://gerrit.wikimedia.org/r/771458

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 16 2022, 11:33 PM

Fixed on beta cluster:

Screen Shot 2022-03-16 at 4.33.27 PM.png (564×1 px, 158 KB)

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 12:00 AM
gerritbot added a comment.Mar 17 2022, 3:46 PM

Change 771395 abandoned by Bernard Wang:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.26] Fix updateUserLinksDropdownItems not being called

Reason:

https://gerrit.wikimedia.org/r/771395

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2022, 4:10 PM
gerritbot added a comment.Mar 17 2022, 4:15 PM

Change 771395 restored by Bernard Wang:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.26] Fix updateUserLinksDropdownItems not being called

https://gerrit.wikimedia.org/r/771395

gerritbot added a project: Patch-For-Review.Mar 17 2022, 4:15 PM
gerritbot added a comment.Mar 17 2022, 6:29 PM

Change 771395 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.26] Fix updateUserLinksDropdownItems not being called

https://gerrit.wikimedia.org/r/771395

Stashbot added a comment.Mar 17 2022, 6:53 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-17T18:53:06Z] <jhuneidi@deploy1002> Synchronized php-1.38.0-wmf.26/skins/Vector/includes/Hooks.php: Backport: [[gerrit:771395|Fix updateUserLinksDropdownItems not being called (T304002)]] (duration: 00m 50s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 17 2022, 7:00 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Mar 17 2022, 8:21 PM
Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

I can verify the fix in production:

Screen Shot 2022-03-17 at 1.21.12 PM.png (560×2 px, 312 KB)

Note due to caching you may need to run action=purge to clear any remaining instances of this.

Jdlrobson removed a parent task: T300202: 1.38.0-wmf.26 deployment blockers.Mar 17 2022, 8:21 PM
ovasileva closed this task as Resolved.Mar 21 2022, 10:44 AM
ovasileva claimed this task.

Looks good! Resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits