Page MenuHomePhabricator
Create Task
Maniphest T304015

Change lu_attached_method to not be an enum
Open, Needs TriagePublic
Actions

Description

It allows us to easier add new methods. Also due to T119173: RFC: Discourage use of MySQL's ENUM type we likely need to do this at some point anyway.

Details

SubjectRepoBranchLines +/-
Document lu_attachment_method columnmediawiki/extensions/CentralAuthmaster+1 -0
maintain-views.yaml: Allow selecting lu_attachment_methodoperations/puppetproduction+2 -1
Add lu_attachment_method migration codemediawiki/extensions/CentralAuthmaster+214 -22
Add lu_attachment_method column to localuser tablemediawiki/extensions/CentralAuthmaster+135 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.Mar 16 2022, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2022, 9:44 PM
gerritbot added a comment.Mar 26 2022, 3:42 AM

Change 773903 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Add gu_attachment_method

https://gerrit.wikimedia.org/r/773903

gerritbot added a project: Patch-For-Review.Mar 26 2022, 3:42 AM
Bugreporter added a parent task: T201477: Mention the status that the account is created due to imported version.Mar 27 2022, 9:26 AM
Bugreporter subscribed.

Alternatively we can somehow deprecate and remove this field completely.

Zabe added a comment.Mar 29 2022, 7:36 PM
In T304015#7808836, @Bugreporter wrote:

Alternatively we can somehow deprecate and remove this field completely.

We could probably also just remove it. I don't think it's really used.

gerritbot added a comment.Apr 1 2022, 11:15 AM

Change 773903 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add lu_attachment_method column to localuser table

https://gerrit.wikimedia.org/r/773903

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 1 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 12:10 PM
gerritbot added a comment.Apr 2 2022, 2:48 PM

Change 776291 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Add lu_attachment_method migration code

https://gerrit.wikimedia.org/r/776291

gerritbot added a project: Patch-For-Review.Apr 2 2022, 2:48 PM
Marostegui closed subtask T305300: Add lu_attachment_method column to localuser table as Resolved.Apr 19 2022, 6:51 AM
Umherirrender moved this task from Unsorted to Change on the Schema-change board.Apr 19 2022, 9:15 PM
gerritbot added a comment.Jun 18 2022, 7:49 PM

Change 804694 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] maintain-views.yaml: Allow selecting lu_attachment_method

https://gerrit.wikimedia.org/r/804694

gerritbot added a comment.Jun 27 2022, 7:11 AM

Change 804694 merged by Ladsgroup:

[operations/puppet@production] maintain-views.yaml: Allow selecting lu_attachment_method

https://gerrit.wikimedia.org/r/804694

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Dec 10 2023, 8:26 PM
Bugreporter mentioned this in T379609: attachAccount.php should not use "login" method.Nov 12 2024, 11:15 AM
gerritbot added a comment.Nov 13 2024, 1:40 PM

Change #1090850 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] Document lu_attachment_method column

https://gerrit.wikimedia.org/r/1090850

gerritbot added a project: Patch-For-Review.Nov 13 2024, 1:40 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptNov 13 2024, 1:40 PM
gerritbot added a comment.Nov 14 2024, 2:00 AM

Change #1090850 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Document lu_attachment_method column

https://gerrit.wikimedia.org/r/1090850

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Nov 14 2024, 3:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits