Page MenuHomePhabricator

Templates with suggested/required parameters do not hide unused parameters by default on multipart when empty
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce

  • Create a template with at least suggested / required parameters and some other parameters. I think it must be at least 4 parameters.
  • Add two templates as part of a transclusion to a page and dont add any parameters
  • Open the transclusion in the VE template dialog

What happens?:

  • The parameters that are neither suggested nor required are not hidden although they are unused
  • The button to hide unused parameters says "Show all fields"

What should have happened instead?:

What I found out so far

Event Timeline

WMDE-Fisch set the point value for this task to 2.Mar 17 2022, 7:28 AM

Change 770940 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Revert "Skip initial creation of unused parameter widget"

https://gerrit.wikimedia.org/r/770940

Change 772833 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix hiding unused template parameters sometimes not working

https://gerrit.wikimedia.org/r/772833

Change 770940 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Revert "Skip initial creation of unused parameter widget"

Reason:

Solved in I6620a870e4420dcb8fecf522b3274458eeec891d

https://gerrit.wikimedia.org/r/770940

Change 772833 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix hiding unused template parameters sometimes not working

https://gerrit.wikimedia.org/r/772833