Page MenuHomePhabricator

Loading performance: Postpone initial widget creation for unused template parameters
Closed, ResolvedPublic5 Estimated Story Points

Description

Since T300640: Hide unused parameters by default in multi-part transclusions the template dialog can open with unused parameters being hidden. The naive implementation does just that: hide the widgets. We assume it will dramatically improve performance (esp. for big multi-part transclusions) when these widgets are not created initially, but only after the "show all fields" button was pressed the first time. From there on pressing the button does a naive show/hide again.

Event Timeline

WMDE-Fisch set the point value for this task to 5.Feb 7 2022, 1:38 PM

Change 761002 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [POC] Skip initial creation of unused parameter widget

https://gerrit.wikimedia.org/r/761002

thiemowmde changed the point value for this task from 5 to 1.Feb 23 2022, 9:35 AM
thiemowmde changed the point value for this task from 1 to 5.Feb 23 2022, 9:42 AM

Change 761002 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Skip initial creation of unused parameter widget

https://gerrit.wikimedia.org/r/761002

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-03-02 board.

Change 770940 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Revert "Skip initial creation of unused parameter widget"

https://gerrit.wikimedia.org/r/770940

Change 770940 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] Revert "Skip initial creation of unused parameter widget"

Reason:

Solved in I6620a870e4420dcb8fecf522b3274458eeec891d

https://gerrit.wikimedia.org/r/770940