Page MenuHomePhabricator
Create Task
Maniphest T304057

Migrate growthexperiments-mentee-overview-filters to growthexperiments-mentee-overview-presets
Closed, ResolvedPublic
Actions

Description

Background & Problem

As part of T294460: When filtering the mentees' table the last choice of filters should be saved, preference growthexperiments-mentee-overview-filters was created as a JSON blob storing filter configuration for the mentees API. However, it doesn't have a field to store page size in. The patch to persist pagesize introduces growthexperiments-mentee-overview-presets as a JSON blob to store all mentee overview-related presets, not just the filters (or just the page size).

Solution

To keep the number of properties the lowest, let's merge those two together.

Notes

This is blocked on r767177 to be merged.

Details

SubjectRepoBranchLines +/-
Mentee overview: Remove growthexperiments-mentee-overview-filters user optionmediawiki/extensions/GrowthExperimentsmaster+5 -170
Mentee overview: Read mentee overview filters from the presets option if availablemediawiki/extensions/GrowthExperimentsmaster+47 -15
Introduce maintenance/migrateMenteeOverviewFiltersToPresets.phpmediawiki/extensions/GrowthExperimentsmaster+154 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Mar 17 2022, 10:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2022, 10:25 AM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Mar 17 2022, 1:18 PM
kostajh subscribed.Mar 17 2022, 2:08 PM

rEGREbd35c9a01a82: Mentee overview: Persist the page size has been merged.

gerritbot added a comment.Apr 2 2022, 3:16 PM

Change 776293 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Read mentee overview filters from the presets option if available

https://gerrit.wikimedia.org/r/776293

gerritbot added a project: Patch-For-Review.Apr 2 2022, 3:16 PM

Change 776294 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Introduce maintenance/migrateMenteeOverviewFiltersToPresets.php

https://gerrit.wikimedia.org/r/776294

gerritbot added a comment.Apr 2 2022, 3:16 PM

Change 776295 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Remove growthexperiments-mentee-overview-filters user option

https://gerrit.wikimedia.org/r/776295

Urbanecm_WMF claimed this task.Apr 2 2022, 3:17 PM
Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 3 2022, 6:23 AM

This is now ready for code review. Should be moved to In progress once merged -- I will need to run the migration script in production to finish this.

Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.Apr 3 2022, 6:23 AM
Urbanecm_WMF moved this task from In progress to In review on the User-Urbanecm_WMF (Engineering) board.Apr 9 2022, 11:59 AM
MShilova_WMF moved this task from New Tasks to Backlog on the GrowthExperiments-Mentorship board.Apr 15 2022, 4:11 PM
gerritbot added a comment.May 5 2022, 2:20 PM

Change 776293 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Read mentee overview filters from the presets option if available

https://gerrit.wikimedia.org/r/776293

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 5 2022, 3:01 PM
gerritbot added a comment.May 7 2022, 7:13 PM

Change 776294 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Introduce maintenance/migrateMenteeOverviewFiltersToPresets.php

https://gerrit.wikimedia.org/r/776294

Stashbot added a comment.May 8 2022, 12:33 PM

Mentioned in SAL (#wikimedia-releng) [2022-05-08T12:33:57Z] <urbanecm> deployment-prep: urbanecm@deployment-mwmaint02:~$ foreachwikiindblist growthexperiments extensions/GrowthExperiments/maintenance/migrateMenteeOverviewFiltersToPresets.php --update # T304057

Urbanecm_WMF moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.May 8 2022, 12:36 PM

The maintenance script needs to be ran in production as well. Should be a part of wmf.12, since wmf.11 was skipped.

Urbanecm_WMF moved this task from In review to Blocked on the User-Urbanecm_WMF (Engineering) board.May 8 2022, 12:36 PM
Stashbot added a comment.May 23 2022, 6:34 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-23T06:34:46Z] <urbanecm> urbanecm@mwmaint1002:~$ foreachwikiindblist growthexperiments extensions/GrowthExperiments/maintenance/migrateMenteeOverviewFiltersToPresets.php --update # T304057

Urbanecm_WMF closed this task as Resolved.May 23 2022, 8:11 AM

Migration happened.

Urbanecm_WMF reopened this task as Open.May 23 2022, 8:13 AM

Still needs the removing patch.

Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 23 2022, 8:14 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2022, 1:56 PM
gerritbot added a comment.May 24 2022, 2:20 PM

Change 776295 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Remove growthexperiments-mentee-overview-filters user option

https://gerrit.wikimedia.org/r/776295

Maintenance_bot removed a project: Patch-For-Review.May 24 2022, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.14; 2022-05-30); removed MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 24 2022, 3:00 PM
Urbanecm_WMF moved this task from Blocked to My Part Done on the User-Urbanecm_WMF (Engineering) board.May 25 2022, 6:10 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 26 2022, 10:44 PM
Etonkovidova closed this task as Resolved.Jun 2 2022, 12:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL