Page MenuHomePhabricator
Create Task
Maniphest T294460

When filtering the mentees' table the last choice of filters should be saved
Closed, ResolvedPublic
Actions

Description

From fr.wp: the filters are useful to exclude some users. But when you return back to the Dashboard, these selected filters are not active anymore. Have a way to save the last set of filters would be useful.

Details

SubjectRepoBranchLines +/-
MenteeOverviewPresets: Add helper methods for known propertiesmediawiki/extensions/GrowthExperimentsmaster+17 -2
MenteeOverviewPresets: Add QUnit testsmediawiki/extensions/GrowthExperimentsmaster+73 -1
Mentee overview: Persist the page sizemediawiki/extensions/GrowthExperimentsmaster+50 -2
Mentee overview: Persist user's last filter choicemediawiki/extensions/GrowthExperimentsmaster+53 -6
Customize query in gerrit

Related Objects

Event Timeline

Trizek-WMF created this task.Oct 27 2021, 5:41 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 27 2021, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF mentioned this in T294461: Mentor dashboard: Add filter for mentees join date/age.Oct 27 2021, 5:43 PM
RG067 subscribed.Oct 27 2021, 6:03 PM
• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Oct 27 2021, 11:37 PM
• mewoph added subscribers: Urbanecm_WMF, • mewoph.

@Urbanecm_WMF perhaps the filters could be serialized in the user's preference?

Urbanecm_WMF added a comment.Nov 22 2021, 8:17 AM
In T294460#7463722, @mewoph wrote:

@Urbanecm_WMF perhaps the filters could be serialized in the user's preference?

Yup, that would be likely the easiest thing to do here. Shouldn't be hard.

Urbanecm_WMF moved this task from Needs Discussion to Upcoming Work on the Growth-Team board.Feb 7 2022, 10:26 AM

I don't think this requires any discussion. Moving to Upcoming work, as it's prioritised in the spreadsheet already.

MMiller_WMF added subscribers: Parkywiki, MMiller_WMF.Feb 7 2022, 7:16 PM

We received the same request from @Parkywiki on English Wikipedia: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Growth_Team_features&type=revision&diff=1070054345&oldid=1070037999&diffmode=source

Urbanecm_WMF mentioned this in T301268: Mentors are confused when an experienced user or users with zero edits show up in their list of mentees.Feb 9 2022, 12:02 PM
Urbanecm_WMF claimed this task.Feb 16 2022, 1:52 PM
Urbanecm_WMF triaged this task as Medium priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team.

It looks like making this happen is relatively easy, so I created a patch for this.

gerritbot added a comment.Feb 16 2022, 1:53 PM

Change 763232 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Persist user's last filter choice

https://gerrit.wikimedia.org/r/763232

gerritbot added a project: Patch-For-Review.Feb 16 2022, 1:53 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 16 2022, 1:59 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 17 2022, 1:55 PM
Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.
gerritbot added a comment.Feb 17 2022, 2:01 PM

Change 763232 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Persist user's last filter choice

https://gerrit.wikimedia.org/r/763232

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2022, 2:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 17 2022, 3:00 PM
Trizek-WMF added a comment.Feb 22 2022, 2:07 PM

@Urbanecm_WMF will it be deployed along with T301268: Mentors are confused when an experienced user or users with zero edits show up in their list of mentees?

Urbanecm_WMF added a comment.Feb 22 2022, 4:17 PM

Yes @Trizek-WMF. Both features should be deployed to Wikipedias this
Thursday.

Trizek-WMF added a project: User-notice.Feb 22 2022, 4:41 PM

Cool! :)

Trizek-WMF moved this task from To Triage to In current Tech/News draft on the User-notice board.Feb 22 2022, 4:41 PM
Urbanecm_WMF moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 1 2022, 1:48 PM

We should also persist the number of mentees displayed (reported as https://www.mediawiki.org/wiki/Topic:Wqxmt1l49iley84m).

gerritbot added a comment.Mar 1 2022, 2:00 PM

Change 767177 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Persist the page size

https://gerrit.wikimedia.org/r/767177

gerritbot added a project: Patch-For-Review.Mar 1 2022, 2:00 PM
Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 1 2022, 2:03 PM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 3 2022, 7:34 PM
MMiller_WMF added a project: GrowthExperiments-Mentorship.Mar 15 2022, 12:48 AM
Urbanecm_WMF mentioned this in T304057: Migrate growthexperiments-mentee-overview-filters to growthexperiments-mentee-overview-presets.Mar 17 2022, 10:25 AM
gerritbot added a comment.Mar 17 2022, 11:41 AM

Change 771572 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] MenteeOverviewPresets: Add QUnit tests

https://gerrit.wikimedia.org/r/771572

gerritbot added a comment.Mar 17 2022, 11:46 AM

Change 771575 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] MenteeOverviewPresets: Add helper methods for known properties

https://gerrit.wikimedia.org/r/771575

gerritbot added a comment.Mar 17 2022, 12:08 PM

Change 767177 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Persist the page size

https://gerrit.wikimedia.org/r/767177

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 17 2022, 1:00 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 17 2022, 1:13 PM
In T294460#7744516, @Urbanecm_WMF wrote:

We should also persist the number of mentees displayed (reported as https://www.mediawiki.org/wiki/Topic:Wqxmt1l49iley84m).

This is now fixed at beta (and will be fixed on production wikis starting Monday March 21). FYI @Trizek-WMF.

gerritbot added a comment.Mar 17 2022, 1:33 PM

Change 771572 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverviewPresets: Add QUnit tests

https://gerrit.wikimedia.org/r/771572

gerritbot added a comment.Mar 17 2022, 1:33 PM

Change 771575 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverviewPresets: Add helper methods for known properties

https://gerrit.wikimedia.org/r/771575

Trizek-WMF closed this task as Resolved.Apr 4 2022, 2:43 PM

No new report came, and the feature works as expected.

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL