Inspector not positioned correctly inside dialogs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 19 2022, 1:44 PM

Project Tags

Referenced Files

	F35020165: Screenshot 2022-03-22 at 18.04.30.png
	Mar 22 2022, 5:07 PM

	F35020140: Screenshot 2022-03-22 at 17.49.48.png
	Mar 22 2022, 5:07 PM

	F35020013: image.png
	Mar 22 2022, 3:03 PM

	F35011963: image.png
	Mar 19 2022, 1:44 PM

Subscribers

Aklapper

EAkinloose

Esanders

Description

Open an image caption which starts with a link, e.g. https://en.wikipedia.org/wiki/Endurance_(1912_ship)?veaction=edit&section=4
Place the cursor at the start of the caption
Observe that the callout triangle is disjointed from the main popup body

This is the same issue as T258501, just in a different context.

Expected:

Open https://en.wikipedia.beta.wmflabs.org/wiki/User:ESanders_(WMF)/sandbox?veaction=edit
Observe the callout triangle is connected to the to the main popup button:

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Update VE core submodule to master (fc0e3ed33)	Bartosz Dziewoński	mediawiki/extensions/VisualEditor	master	+1 -1
	Pass overlay padding when building desktop context (inspector)	Esanders	VisualEditor/VisualEditor	master	+11 -2

Customize query in gerrit

Related Objects

Mentioned In: T258501: VE inspector is not positioned correctly near edge of content area when New Vector is enabled
Mentioned Here: T258501: VE inspector is not positioned correctly near edge of content area when New Vector is enabled

Event Timeline

Esanders created this task.Mar 19 2022, 1:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2022, 1:44 PM

Esanders mentioned this in T258501: VE inspector is not positioned correctly near edge of content area when New Vector is enabled.Mar 19 2022, 1:44 PM

Change 771990 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Pass overlay padding when building desktop context (inspector)

https://gerrit.wikimedia.org/r/771990

gerritbot added a project: Patch-For-Review.Mar 19 2022, 1:46 PM

Esanders claimed this task.Mar 19 2022, 1:49 PM

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Change 771990 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Pass overlay padding when building desktop context (inspector)

https://gerrit.wikimedia.org/r/771990

Change 772534 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)

https://gerrit.wikimedia.org/r/772534

Change 772534 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)

https://gerrit.wikimedia.org/r/772534

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 1:10 AM

• matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 22 2022, 1:47 AM

• matmarex added a project: Editing QA.

Esanders updated the task description. (Show Details)Mar 22 2022, 3:03 PM

All good on this now. See:

Screenshot 2022-03-22 at 17.49.48.png (1,062×556 px, 46 KB)

Screenshot 2022-03-22 at 18.04.30.png (1,024×1,132 px, 707 KB)

This covers for https://phabricator.wikimedia.org/T258501 as well.

EAkinloose edited projects, added: Verified; removed: Editing QA.Mar 22 2022, 5:11 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Mar 26 2022, 1:20 AM

Inspector not positioned correctly inside dialogsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Inspector not positioned correctly inside dialogs
Closed, ResolvedPublic
Actions