Page MenuHomePhabricator
Create Task
Maniphest T304202

Inspector not positioned correctly inside dialogs
Closed, ResolvedPublic
Actions

Description

image.png (457×526 px, 58 KB)

This is the same issue as T258501, just in a different context.

Expected:

image.png (296×476 px, 25 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (fc0e3ed33)mediawiki/extensions/VisualEditormaster+1 -1
Pass overlay padding when building desktop context (inspector)VisualEditor/VisualEditormaster+11 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 19 2022, 1:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2022, 1:44 PM
Esanders mentioned this in T258501: VE inspector is not positioned correctly near edge of content area when New Vector is enabled.Mar 19 2022, 1:44 PM
gerritbot added a comment.Mar 19 2022, 1:46 PM

Change 771990 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Pass overlay padding when building desktop context (inspector)

https://gerrit.wikimedia.org/r/771990

gerritbot added a project: Patch-For-Review.Mar 19 2022, 1:46 PM
Esanders claimed this task.Mar 19 2022, 1:49 PM
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Esanders moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Mar 22 2022, 12:27 AM

Change 771990 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Pass overlay padding when building desktop context (inspector)

https://gerrit.wikimedia.org/r/771990

gerritbot added a comment.Mar 22 2022, 12:34 AM

Change 772534 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)

https://gerrit.wikimedia.org/r/772534

gerritbot added a comment.Mar 22 2022, 12:49 AM

Change 772534 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fc0e3ed33)

https://gerrit.wikimedia.org/r/772534

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 1:10 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 22 2022, 1:47 AM
matmarex added a project: Editing QA.
Esanders updated the task description. (Show Details)Mar 22 2022, 3:03 PM
EAkinloose subscribed.Mar 22 2022, 5:07 PM

All good on this now. See:

Screenshot 2022-03-22 at 17.49.48.png (556×1 px, 46 KB)

Screenshot 2022-03-22 at 18.04.30.png (1×1 px, 707 KB)

This covers for https://phabricator.wikimedia.org/T258501 as well.

EAkinloose edited projects, added Verified; removed Editing QA.Mar 22 2022, 5:11 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Mar 26 2022, 1:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits