Page MenuHomePhabricator
Create Task
Maniphest T304366

Ensure all DesktopWebUIActionsTracking events are correctly logged for menus
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
bwang
Mar 21 2022, 8:27 PM
Tags
Referenced Files
F35032898: Screen Shot 2022-03-31 at 6.26.35 PM.png
Apr 1 2022, 1:35 AM
F35032900: Screen Shot 2022-03-31 at 6.27.53 PM.png
Apr 1 2022, 1:35 AM
F35032902: Screen Shot 2022-03-31 at 6.28.29 PM.png
Apr 1 2022, 1:35 AM
F35032896: Screen Shot 2022-03-31 at 6.30.51 PM.png
Apr 1 2022, 1:33 AM
F35032892: Screen Shot 2022-03-31 at 6.33.01 PM.png
Apr 1 2022, 1:33 AM
F35032894: Screen Shot 2022-03-31 at 6.32.16 PM.png
Apr 1 2022, 1:33 AM
F35028757: Screen Shot 2022-03-29 at 10.10.06 AM.png
Mar 29 2022, 5:11 PM
F35014484: Screen Shot 2022-03-21 at 3.19.36 PM.png
Mar 21 2022, 8:27 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
ovasileva

Description

Background

Around Oct 2021, changes were made to Vector's menu HTML to better support icons. The introduction of a wrapper span element introduced a bug to our event logging, where clicks on menu item text would not log an event.

Clicks to the areas surrounded by the red dotted line would not log an event

Screen Shot 2022-03-21 at 3.19.36 PM.png (353×539 px, 30 KB)

This has impacted our data for clicks on menu items, most notably to the user links menu items, and the sticky header user links menu items.

QA steps

  1. Trigger a click event on one of of the user menu items in the beta cluster by clicking on the text of the label. Inspect the network tab to check a request to events is made.

Screen Shot 2022-03-29 at 10.10.06 AM.png (640×2 px, 245 KB)

  1. Trigger a click event in the beta cluster by clicking outside the text of the label.
  1. Trigger a click event in the beta cluster by clicking on the icon inside the menu item

QA Results - Beta

ACStatusDetails
1✅T304366#7823773
2✅T304366#7823773
3✅T304366#7823773

QA Results - Prod

ACStatusDetails
1✅T304366#7823776
2✅T304366#7823776
3✅T304366#7823776

Details

SubjectRepoBranchLines +/-
Ensure events are correctly logged for text wrapped in spansmediawiki/extensions/WikimediaEventsmaster+24 -10
mobileWebUIActions: Fix action logging event twicemediawiki/extensions/WikimediaEventsmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

bwang created this task.Mar 21 2022, 8:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2022, 8:27 PM
gerritbot added a comment.Mar 21 2022, 8:28 PM

Change 771704 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/WikimediaEvents@master] Ensure events are correctly logged for text wrapped in spans

https://gerrit.wikimedia.org/r/771704

gerritbot added a project: Patch-For-Review.Mar 21 2022, 8:28 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Mar 21 2022, 11:55 PM
ovasileva subscribed.Mar 22 2022, 9:38 AM
ovasileva triaged this task as High priority.Mar 22 2022, 2:38 PM
Jdlrobson mentioned this in T298873: Analyze results of sticky header A/B test.Mar 22 2022, 3:01 PM
Jdlrobson claimed this task.Mar 22 2022, 4:18 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 23 2022, 5:21 PM
bwang removed Jdlrobson as the assignee of this task.Mar 23 2022, 6:47 PM
bwang assigned this task to Jdlrobson.
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang added a subscriber: Jdlrobson.
gerritbot added a comment.Mar 23 2022, 7:14 PM

Change 771704 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Ensure events are correctly logged for text wrapped in spans

https://gerrit.wikimedia.org/r/771704

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 23 2022, 7:17 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 23 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 8:11 PM
gerritbot added a comment.Mar 23 2022, 8:15 PM

Change 773338 had a related patch set uploaded (by Krinkle; author: Bernard Wang):

[mediawiki/extensions/WikimediaEvents@master] mobileWebUIActions: Fix action logging event twice

https://gerrit.wikimedia.org/r/773338

gerritbot added a project: Patch-For-Review.Mar 23 2022, 8:15 PM
gerritbot added a comment.Mar 23 2022, 8:25 PM

Change 773338 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] mobileWebUIActions: Fix action logging event twice

https://gerrit.wikimedia.org/r/773338

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2022, 9:10 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Mar 29 2022, 5:11 PM
Jdlrobson updated the task description. (Show Details)
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 1 2022, 1:33 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Trigger a click event on one of of the user menu items in the beta cluster by clicking on the text of the label. Inspect the network tab to check a request to events is made.

Screen Shot 2022-03-31 at 6.30.51 PM.png (1×1 px, 249 KB)

✅ AC2: Trigger a click event in the beta cluster by clicking outside the text of the label.

Screen Shot 2022-03-31 at 6.32.16 PM.png (1×1 px, 222 KB)

✅ AC3: Trigger a click event in the beta cluster by clicking on the icon inside the menu item

Screen Shot 2022-03-31 at 6.33.01 PM.png (1×751 px, 228 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Apr 1 2022, 1:35 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Trigger a click event on one of of the user menu items in the beta cluster by clicking on the text of the label. Inspect the network tab to check a request to events is made.

Screen Shot 2022-03-31 at 6.26.35 PM.png (858×1 px, 184 KB)

✅ AC2: Trigger a click event in the beta cluster by clicking outside the text of the label.

Screen Shot 2022-03-31 at 6.27.53 PM.png (882×894 px, 172 KB)

✅ AC3: Trigger a click event in the beta cluster by clicking on the icon inside the menu item

Screen Shot 2022-03-31 at 6.28.29 PM.png (862×1 px, 194 KB)

Edtadros updated the task description. (Show Details)Apr 1 2022, 1:36 AM
ovasileva mentioned this in T305454: Data QA of T304366: Ensure all DesktopWebUIActionsTracking events are correctly logged for menus.Apr 5 2022, 11:20 AM
ovasileva closed this task as Resolved.Apr 5 2022, 11:28 AM

Resolving, further QA will be done in T305454: Data QA of T304366: Ensure all DesktopWebUIActionsTracking events are correctly logged for menus

ovasileva closed subtask T305454: Data QA of T304366: Ensure all DesktopWebUIActionsTracking events are correctly logged for menus as Resolved.Jun 7 2022, 5:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits