[wmf.2 -regression] (minor) Add image - trash bin icon is misplaced
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Mar 22 2022, 1:19 AM

Description

On any wiki with enabled Add image task, go to an article with Add image recommendation.
Answer "yes" to add an image - the trash bin in "Add image" box is misplaced.

Screen Shot 2022-03-21 at 6.08.10 PM.png (996×644 px, 623 KB)

Screen Shot 2022-03-21 at 6.15.38 PM.png (886×528 px, 147 KB)

Screen Shot 2022-03-21 at 5.56.52 PM.png (1×594 px, 414 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Add an image: fix placement of delete button	mediawiki/extensions/GrowthExperiments	master	+2 -2

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Mar 22 2022, 1:19 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2022, 1:19 AM

Etonkovidova renamed this task from [wmf.2 -regression] (minor) Add image - mw-ge-recommendedImage-header displayed on two lines to [wmf.2 -regression] (minor) Add image - trash bin icon is misplaced.Mar 22 2022, 1:22 AM

Etonkovidova updated the task description. (Show Details)

• mewoph claimed this task.Mar 22 2022, 4:01 PM

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

The selector we were overriding for figure[typeof~='mw:Image/Thumb'] increased in specificity, from

figure[typeof~='mw:Image/Thumb'] > *:first-child > span to
figure[typeof~='mw:Image/Thumb'] > *:first-child > span:first-child

Change 772874 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: fix placement of delete button

https://gerrit.wikimedia.org/r/772874

gerritbot added a project: Patch-For-Review.Mar 22 2022, 4:22 PM

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 22 2022, 4:22 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 22 2022, 7:19 PM

Change 772874 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: fix placement of delete button

https://gerrit.wikimedia.org/r/772874

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.4; 2022-03-23).Mar 22 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 8:10 PM

Checked in beta - looks good.

Etonkovidova closed this task as Resolved.Mar 24 2022, 6:34 PM

	F35014905: Screen Shot 2022-03-21 at 5.56.52 PM.png
	Mar 22 2022, 1:22 AM

	F35014895: Screen Shot 2022-03-21 at 6.08.10 PM.png
	Mar 22 2022, 1:19 AM

	F35014900: Screen Shot 2022-03-21 at 6.15.38 PM.png
	Mar 22 2022, 1:19 AM

[wmf.2 -regression] (minor) Add image - trash bin icon is misplacedClosed, ResolvedPublicActions

Description

Details

Event Timeline

[wmf.2 -regression] (minor) Add image - trash bin icon is misplaced
Closed, ResolvedPublic
Actions