Fix use of errorbox in Gadgets
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tacsipacsi
	Mar 24 2022, 2:20 PM

Description

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace span.errorbox with div.mw-message-box-error	mediawiki/extensions/Gadgets	master	+5 -5

Status	Assigned	Task
Resolved	ovasileva	T299625 Bug: New language notice inconsistently styled across wikis
Resolved	Jdlrobson	T270796 Message boxes classes should carry `mw-`
Resolved	Jdlrobson	T300306 [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release
Resolved	Tacsipacsi	T304602 Fix use of errorbox in Gadgets

As I touched the code anyway, I decided to fix a visual issue along the way, so the patch I’ll upload shortly causes visual changes:

Before	After

Change 773518 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/extensions/Gadgets@master] Replace span.errorbox with div.mw-message-box-error

Tacsipacsi changed the task status from Open to In Progress.Mar 24 2022, 3:17 PM

Appears to work with the new Html method:

Thanks for helping us improve this code @Tacsipacsi !

Change 773518 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Replace span.errorbox with div.mw-message-box-error

Jdlrobson closed this task as Resolved.Mar 24 2022, 4:39 PM

	F35022410: Screen Shot 2022-03-24 at 8.39.41 AM.png
	Mar 24 2022, 3:40 PM

	F35022343: Screenshot 2022-03-24 at 15-31-53 Gadgets - Wikihírek.png
	Mar 24 2022, 2:34 PM

	F35022341: Screenshot 2022-03-24 at 15-31-09 Gadgets - Wikihírek.png
	Mar 24 2022, 2:34 PM