NOTE: Please create subtasks to manage works by your team. Your assistance is greatly appreciated.
These classes conflict with on wiki styles so will be replaced with new classes.
This impacts any code which is declaring the old class.
We need to update various instances of https://codesearch.wmcloud.org/deployed/?q=%5B%27%22%20%5C.%5D(error%7Csuccess%7Cwarning%7Cmessage)box%5B%5E%5C.%5D&i=nope&files=&excludeFiles=(stories%2F.*%7Ctest%2Ffixtures%2F*%7Cwmf-config%2FCommonSettings.php%7Cresources%2Fext.nearby.scripts%2FErrorbox.vue%7Ctests%2Fcases%2F.*%7Ci18n%2F%5B%5Ee%5D.*json%7Chandlebars%2Fcompiled%7Ctests%2Fjest%2FApp.test.js)&repos=
To avoid breakage
- Skins should ensure they are enabling the interface-message-box feature inside the module that is used in ResourceLoaderSkinModule or update their CSS selectors to include the new classes https://gerrit.wikimedia.org/g/mediawiki/core/+/7c2187f48c7ebf5c2b7dd94604dc911d26445998/includes/Html.php#762
- Extensions overriding the styles should update their own styles and should consider using their own dedicated class selector to do this.
- Extensions must call Html::noticeBox, Html::warningBox, Html::errorBox rather than directly specify the class
Before:
Html::rawElement( 'div', [ 'class' => 'warningbox' ], $ctx->msg( 'confirmedit-preview-description' )->parse() )
After:
Html::warningBox( $ctx->msg( 'confirmedit-preview-description' )->parse() )
- In JavaScript, there is currently no API. You will need to hardcode the classes for now to use mw-message-box and mw-message-box-(warning|success|error) (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/757765 for more context on why there is currently no JavaScript API)
- Update any Output::wrapWikiMsg methods
Before:
$out->wrapWikiMsg( "<div class='errorbox'>\n$1\n</div>\n", [ 'missing-revision', $this->oldid ] );
After:
use Html; $out->addHTML( Html::errorBox( $out->msg( 'missing-revision', $this->oldid )->parse() ) );
Before:
$this->getOutput()->wrapWikiTextAsInterface( 'errorbox', $wikitext );
After:
$out = $this->getOutput(); $out->addHTML( Html::errorBox( $out->parseAsContent( $wikitext ) ) );