Page MenuHomePhabricator
Create Task
Maniphest T300330

Fix uses of (error|success|warning|message)box in Translate
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

See T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release for details.

Details

SubjectRepoBranchLines +/-
Add MW < 1.38 compatibility for (success|warning) box CSS classesmediawiki/extensions/Translatemaster+10 -3
Fix uses of (error|success|warning)box in Translatemediawiki/extensions/Translatemaster+69 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Jan 28 2022, 7:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2022, 7:13 AM
Nikerabbit added a parent task: T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release.Jan 28 2022, 7:14 AM
Nikerabbit triaged this task as Medium priority.Feb 14 2022, 11:34 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
Nikerabbit set the point value for this task to 4.Mar 14 2022, 2:46 PM
abi_ added a project: Language-Team (Language-2022-January-March).Mar 15 2022, 9:13 AM
abi_ moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.
abi_ subscribed.

Time sensitive task: Once MW 1.39 is released, users will start noticing visual inconsistencies.

gerritbot added a comment.Mar 21 2022, 5:04 AM

Change 772056 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/extensions/Translate@master] Fix uses of (error|success|warning)box in Translate

https://gerrit.wikimedia.org/r/772056

gerritbot added a project: Patch-For-Review.Mar 21 2022, 5:04 AM
Stang claimed this task.Mar 21 2022, 5:05 AM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-January-March) board.Mar 23 2022, 2:23 PM
gerritbot added a comment.Mar 24 2022, 11:48 AM

Change 772056 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix uses of (error|success|warning)box in Translate

https://gerrit.wikimedia.org/r/772056

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 24 2022, 12:11 PM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-January-March) board.Mar 24 2022, 12:33 PM
TheresNoTime subscribed.Mar 25 2022, 5:55 PM

Just noting that I've granted @Stang translation admin rights on the beta cluster so that they can test this

Stang closed this task as Resolved.Mar 25 2022, 6:58 PM
Nikerabbit reopened this task as Open.Mar 28 2022, 9:28 AM

Re-opening to follow Language team's process of closing after verification in production.

Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Apr 4 2022, 8:24 AM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2022-April-June) board.
Nikerabbit moved this task from Recheck after deployment to Priority: Localization infrastructure on the Language-Team (Language-2022-April-June) board.Apr 5 2022, 7:46 AM

Production looks fine, but per code review comments, I am thinking this might break for MW <1.38 some cases. Should be tested for next MLEB release.

gerritbot added a comment.Apr 18 2022, 2:03 PM

Change 783847 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add MW < 1.38 compatibility for (error|success|warning) boxes

https://gerrit.wikimedia.org/r/783847

gerritbot added a project: Patch-For-Review.Apr 18 2022, 2:03 PM
Nikerabbit moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-April-June) board.Apr 19 2022, 7:26 AM
gerritbot added a comment.Apr 20 2022, 8:18 AM

Change 783847 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add MW < 1.38 compatibility for (success|warning) box CSS classes

https://gerrit.wikimedia.org/r/783847

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2022, 8:31 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.9; 2022-04-25); removed MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Apr 20 2022, 9:00 AM
Stang added a comment.May 7 2022, 3:28 PM

@Nikerabbit Still waiting for something?

abi_ closed this task as Resolved.May 9 2022, 6:09 AM
abi_ moved this task from In Review to Done on the Language-Team (Language-2022-April-June) board.

This is done. Marking it as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL