Page MenuHomePhabricator

Bug: New language notice inconsistently styled across wikis
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Go to https://ko.wikipedia.org/wiki/%EC%9D%BC%EB%B0%98%EC%83%81%EB%8C%80%EB%A1%A0_%EA%B0%9C%EB%A1%A0 and open the sidebar

Expected:
New language notice should look the same as in

Screen Shot 2021-12-07 at 1.35.17 PM.png (1×2 px, 662 KB)

Observed:
New language notice appears squished

Screen Shot 2022-01-20 at 9.25.48 AM.png (1×346 px, 76 KB)

QA Results - Beta

ACStatusDetails
1T299625#7702733

QA Results - Prod

ACStatusDetails
1T299625#7702737

Related Objects

StatusSubtypeAssignedTask
Resolvedovasileva
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedStang
ResolvedStang
OpenNone
OpenNone
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedSgs
ResolvedWMDE-Fisch
ResolvedLucas_Werkmeister_WMDE
ResolvedJdlrobson
ResolvedStang
Resolvedmatmarex
ResolvedSimoneThisDot
ResolvedEtonkovidova
ResolvedStang
ResolvedJdlrobson
ResolvedStang
ResolvedTacsipacsi
ResolvedSamwalton9
ResolvedSamwalton9
ResolvedJdlrobson
Resolvedabi_
DeclinedNone
ResolvedStang
ResolvedStang
ResolvedTacsipacsi
ResolvedTacsipacsi
OpenNone
ResolvedTacsipacsi
ResolvedSamwalton9
ResolvedSgs
ResolvedJdlrobson
OpenNone

Event Timeline

Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdlrobson.

This was caused by an onwiki style:
https://ko.wikipedia.org/w/index.php?title=%EB%AF%B8%EB%94%94%EC%96%B4%EC%9C%84%ED%82%A4%3ACommon.css&type=revision&diff=31353038&oldid=30499211

When we're seeing these issues we should always check ?safemode=1 to see where the fault lies.

Half the fleet. That's ignoring 700 users with some variant of it.

NB .messagebox is in almost all cases a local use of that class (which I believe is the originator) rather than a re-use/re-skin of the Wikimedia-side class.

T270796: Message boxes classes should carry `mw-` is directly relevant. Fixing 450 wikis would be prevented by renaming the class on the MediaWiki side. (No comment on the other two classes discussed in that task.)

T270796: Message boxes classes should carry mw- is directly relevant. Fixing 450 wikis would be prevented by renaming the class on the MediaWiki side. (No comment on the other two classes discussed in that task.)

Okay it sounds like we have two options:

  1. Restrict these styles to content area by manually change every instance of .messagebox to .mw-body-content .messagebox
  2. Push ahead with T270796 renaming the class, at risk of breaking things that might be dependent on the Wikimedia styles. There is no existing policy saying these styles can be safely relied on but this may cause some irritation even with a breaking change User-notice.

Personally I recommend option 2 at this point.

Change 757763 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Language alert box should use Html::noticeBox

https://gerrit.wikimedia.org/r/757763

Change 757763 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Language alert box should use Html::noticeBox

https://gerrit.wikimedia.org/r/757763

Test Result - Beta

Status: ✅ PASS
Environment: enbeta, kobeta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The new language links notice should not be squished.

Screen Shot 2022-02-10 at 3.20.48 PM.png (744×1 px, 132 KB)

Screen Shot 2022-02-10 at 3.21.07 PM.png (704×1 px, 114 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: kowiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The new language links notice should not be squished.

https://ko.wikipedia.org/wiki/%EC%9D%BC%EB%B0%98%EC%83%81%EB%8C%80%EB%A1%A0_%EA%B0%9C%EB%A1%A0

Screen Shot 2022-02-10 at 3.24.09 PM.png (945×416 px, 186 KB)

Screen Shot 2022-02-10 at 3.24.19 PM.png (903×440 px, 171 KB)

Looks good, resolving