Page MenuHomePhabricator
Create Task
Maniphest T299625

Bug: New language notice inconsistently styled across wikis
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
ovasileva
Jan 20 2022, 8:33 AM
Tags
Referenced Files
F34947914: Screen Shot 2022-02-10 at 3.24.09 PM.png
Feb 10 2022, 11:28 PM
F34947915: Screen Shot 2022-02-10 at 3.24.19 PM.png
Feb 10 2022, 11:28 PM
F34947911: Screen Shot 2022-02-10 at 3.21.07 PM.png
Feb 10 2022, 11:23 PM
F34947910: Screen Shot 2022-02-10 at 3.20.48 PM.png
Feb 10 2022, 11:23 PM
F34924127: Screen Shot 2022-01-20 at 9.25.48 AM.png
Jan 20 2022, 8:33 AM
F34856462: Screen Shot 2021-12-07 at 1.35.17 PM.png
Jan 20 2022, 8:33 AM
Subscribers
Aklapper
Edtadros
Izno
Jdlrobson
ovasileva
revi

Description

Steps to reproduce

  1. Go to https://ko.wikipedia.org/wiki/%EC%9D%BC%EB%B0%98%EC%83%81%EB%8C%80%EB%A1%A0_%EA%B0%9C%EB%A1%A0 and open the sidebar

Expected:
New language notice should look the same as in

Screen Shot 2021-12-07 at 1.35.17 PM.png (1×2 px, 662 KB)

Observed:
New language notice appears squished

Screen Shot 2022-01-20 at 9.25.48 AM.png (1×346 px, 76 KB)

QA Results - Beta

ACStatusDetails
1✅T299625#7702733

QA Results - Prod

ACStatusDetails
1✅T299625#7702737

Details

SubjectRepoBranchLines +/-
Language alert box should use Html::noticeBoxmediawiki/skins/Vectormaster+4 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedovasilevaT299625 Bug: New language notice inconsistently styled across wikis
 ResolvedJdlrobsonT270796 Message boxes classes should carry `mw-`
 ResolvedJdlrobsonT300306 [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release
 ResolvedStangT300330 Fix uses of (error|success|warning|message)box in Translate
 ResolvedStangT300332 Fix use of successbox in TranslationNotifications
 ResolvedNikerabbitT300333 Fix uses of (error|success|warning|message)box in WikibaseStatementUpdater
 ResolvedNikerabbitT300334 Fix uses of (error|success|warning|message)box in FileSystemImageServer
 ResolvedNikerabbitT300331 Fix uses of (error|success|warning|message)box in Ainut
 ResolvedWMDE-FischT300342 Fix use of warningbox in TwoColConflict
 ResolvedWMDE-FischT300343 Fix uses of error- and warningbox in FileImporter
 ResolvedSgsT300346 Fix uses of (error|success|warning|message)box in GrowthExperiments
 ResolvedWMDE-FischT300349 Fix use of errorbox in TemplateData
 ResolvedLucas_Werkmeister_WMDET300354 Fix use of errorbox in Wikibase (FederatedPropertiesError)
 ResolvedJdlrobsonT300356 Fix use of warningbox in Wikibase (error handling selenium test)
 ResolvedStangT300358 Fix uses of (error|warning)box (MediaWiki core)
 ResolvedmatmarexT301401 Update DiscussionTools for warningbox changes
 ResolvedSimoneThisDotT302781 [M] Fix uses of (error|success|warning|message)box in Upload Wizard
 ResolvedEtonkovidovaT302782 [M] Edit Task: Fix uses of (error|success|warning|message)box in MachineVision
 ResolvedStangT303685 Fix use of warningbox in GlobalBlocking
 ResolvedJdlrobsonT304241 Fix uses of errorbox in CheckUser
 ResolvedStangT304248 Fix uses of (error|warning|success)box in CentralAuth
 ResolvedTacsipacsiT304271 Fix uses of (error|warning)box in FlaggedRevs
 ResolvedSamwalton9-WMFT304270 Fix use of errorbox in SpamBlacklist
 ResolvedSamwalton9-WMFT304269 Fix use of errorbox in TitleBlacklist
 ResolvedJdlrobsonT304272 Fix use of warningbox in ConfirmEdit
 Resolvedabi_T304273 Fix use of warningbox in MassMessage
 DeclinedNoneT304275 Fix use of errorbox in Scribunto
 ResolvedStangT304277 Fix uses of (error|warning)box in TemplateSandbox
 ResolvedStangT304243 Replace (error|warning|success)box in test cases of AbuseFilter
 ResolvedTacsipacsiT304531 Score extension using deprecated errorbox class
 ResolvedTacsipacsiT304602 Fix use of errorbox in Gadgets
 OpenNoneT304760 Fix use of errorbox in SemanticACL
 ResolvedTacsipacsiT304767 Fix uses of (error|warning)box in CirrusSearch
 ResolvedSamwalton9-WMFT304769 Fix uses of errorbox in CentralNotice
 ResolvedSgsT304890 Fix uses of (error|success|warning|message)box in Flow
 ResolvedJdlrobsonT304363 Remove message boxes with IDs in core
 OpenNoneT307018 [mediawiki.notification.convertmessagebox.js] Replace data-mw-auto-hide attribute logic with mw-notify-success-persistent or remove it

Event Timeline

ovasileva created this task.Jan 20 2022, 8:33 AM
Restricted Application added subscribers: revi, Aklapper. · View Herald TranscriptJan 20 2022, 8:33 AM
ovasileva triaged this task as Medium priority.Jan 20 2022, 8:33 AM
ovasileva added projects: Web-Team-Backlog (Kanbanana-FY-2021-22), Desktop Improvements (Vector 2022).
ovasileva moved this task from Incoming to Language Switching on the Desktop Improvements (Vector 2022) board.
Jdlrobson closed this task as Resolved.Jan 20 2022, 4:19 PM
Jdlrobson claimed this task.
Jdlrobson added a project: Local-Wiki-Template-And-Gadget-Issues.
Jdlrobson subscribed.

This was caused by an onwiki style:
https://ko.wikipedia.org/w/index.php?title=%EB%AF%B8%EB%94%94%EC%96%B4%EC%9C%84%ED%82%A4%3ACommon.css&type=revision&diff=31353038&oldid=30499211

When we're seeing these issues we should always check ?safemode=1 to see where the fault lies.

Jdlrobson reopened this task as Open.Jan 20 2022, 6:21 PM

@ovasileva as discussed let me know which other wikis are impacted.
I've fixed Thai https://th.wikipedia.org/w/index.php?title=%E0%B8%A1%E0%B8%B5%E0%B9%80%E0%B8%94%E0%B8%B5%E0%B8%A2%E0%B8%A7%E0%B8%B4%E0%B8%81%E0%B8%B4:Common.css&oldid=9878426

Jdlrobson reassigned this task from Jdlrobson to ovasileva.Jan 20 2022, 6:21 PM
Izno subscribed.Jan 20 2022, 6:51 PM

Half the fleet. That's ignoring 700 users with some variant of it.

Izno added a comment.EditedJan 20 2022, 6:54 PM

NB .messagebox is in almost all cases a local use of that class (which I believe is the originator) rather than a re-use/re-skin of the Wikimedia-side class.

T270796: Message boxes classes should carry `mw-` is directly relevant. Fixing 450 wikis would be prevented by renaming the class on the MediaWiki side. (No comment on the other two classes discussed in that task.)

Jdlrobson added a comment.Jan 20 2022, 7:20 PM

T270796: Message boxes classes should carry mw- is directly relevant. Fixing 450 wikis would be prevented by renaming the class on the MediaWiki side. (No comment on the other two classes discussed in that task.)

Okay it sounds like we have two options:

  1. Restrict these styles to content area by manually change every instance of .messagebox to .mw-body-content .messagebox
  2. Push ahead with T270796 renaming the class, at risk of breaking things that might be dependent on the Wikimedia styles. There is no existing policy saying these styles can be safely relied on but this may cause some irritation even with a breaking change User-notice.

Personally I recommend option 2 at this point.

Jdlrobson mentioned this in T270796: Message boxes classes should carry `mw-`.Jan 20 2022, 7:22 PM
Jdlrobson added a subtask: T270796: Message boxes classes should carry `mw-`.
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 24 2022, 6:14 PM
ovasileva reassigned this task from ovasileva to Jdlrobson.Jan 27 2022, 6:13 PM
Jdlrobson added a comment.Jan 27 2022, 6:13 PM

This is blocked on T270796.

Jdlrobson removed Jdlrobson as the assignee of this task.Jan 27 2022, 10:24 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jan 27 2022, 10:25 PM

Change 757763 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Language alert box should use Html::noticeBox

https://gerrit.wikimedia.org/r/757763

gerritbot added a project: Patch-For-Review.Jan 27 2022, 10:25 PM
Jdlrobson added a comment.Jan 27 2022, 10:26 PM

No longer blocked.

gerritbot added a comment.Jan 31 2022, 5:05 PM

Change 757763 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Language alert box should use Html::noticeBox

https://gerrit.wikimedia.org/r/757763

Maintenance_bot removed a project: Patch-For-Review.Jan 31 2022, 5:11 PM
Jdlrobson assigned this task to Edtadros.Jan 31 2022, 5:58 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 6:00 PM
Izno mentioned this in T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release.Feb 10 2022, 6:49 AM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 10 2022, 11:23 PM

Test Result - Beta

Status: ✅ PASS
Environment: enbeta, kobeta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The new language links notice should not be squished.

Screen Shot 2022-02-10 at 3.20.48 PM.png (744×1 px, 132 KB)

Screen Shot 2022-02-10 at 3.21.07 PM.png (704×1 px, 114 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Feb 10 2022, 11:28 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: kowiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The new language links notice should not be squished.

https://ko.wikipedia.org/wiki/%EC%9D%BC%EB%B0%98%EC%83%81%EB%8C%80%EB%A1%A0_%EA%B0%9C%EB%A1%A0

Screen Shot 2022-02-10 at 3.24.09 PM.png (945×416 px, 186 KB)

Screen Shot 2022-02-10 at 3.24.19 PM.png (903×440 px, 171 KB)

Edtadros updated the task description. (Show Details)Feb 10 2022, 11:29 PM
ovasileva closed this task as Resolved.Feb 11 2022, 12:06 PM

Looks good, resolving

Jdlrobson closed subtask T270796: Message boxes classes should carry `mw-` as Resolved.Apr 19 2022, 10:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL