Page MenuHomePhabricator
Create Task
Maniphest T305029

wikitech still relies on OATHAuth legacy single-key (was PHP Notice: Undefined index: keys)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: keys
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.5/extensions/OATHAuth/src/OATHUserRepository.php(98)
#0 /srv/mediawiki/php-1.39.0-wmf.5/extensions/OATHAuth/src/OATHUserRepository.php(98): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.5/extensions/OATHAuth/src/Hook/HookHandler.php(98): MediaWiki\Extension\OATHAuth\OATHUserRepository->findByUser(User)
#2 /srv/mediawiki/php-1.39.0-wmf.5/includes/HookContainer/HookContainer.php(160): MediaWiki\Extension\OATHAuth\Hook\HookHandler->onGetPreferences(User, array)
#3 /srv/mediawiki/php-1.39.0-wmf.5/includes/HookContainer/HookRunner.php(1913): MediaWiki\HookContainer\HookContainer->run(string, array)
#4 /srv/mediawiki/php-1.39.0-wmf.5/includes/preferences/DefaultPreferencesFactory.php(249): MediaWiki\HookContainer\HookRunner->onGetPreferences(User, array)
#5 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiOptions.php(205): MediaWiki\Preferences\DefaultPreferencesFactory->getFormDescriptor(User, DerivativeContext)
#6 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiOptions.php(115): ApiOptions->getPreferences()
#7 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(1897): ApiOptions->execute()
#8 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(871): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(842): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.39.0-wmf.5/api.php(90): ApiMain->execute()
#11 /srv/mediawiki/php-1.39.0-wmf.5/api.php(45): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}
Impact
Notes

Comes from an OATHAuth hook ( https://www.mediawiki.org/wiki/Extension:OATHAuth ) while browsing Special:RecentChanges on https://wikitech.wikimedia.org

Details

Request URL
https://wikitech.wikimedia.org/w/api.php
SubjectRepoBranchLines +/-
Revert "OATHUserRepository: Stop handling legacy single-key"mediawiki/extensions/OATHAuthmaster+5 -1
Revert "OATHUserRepository: Stop handling legacy single-key"mediawiki/extensions/OATHAuthwmf/1.39.0-wmf.5+5 -1
Customize query in gerrit

Related Objects

Event Timeline

hashar triaged this task as Unbreak Now! priority.Mar 30 2022, 8:25 AM
hashar created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 8:25 AM
hashar added a parent task: T300204: 1.39.0-wmf.5 deployment blockers.Mar 30 2022, 8:25 AM
hashar added a comment.EditedMar 30 2022, 8:28 AM

Beside l10n update, there have been no recent modifications to OATHAuth extension :-\

My local copy of the repository was not up-to-date. We had:

$ git releasenotes --no-merges origin/wmf/1.39.0-wmf.4..origin/wmf/1.39.0-wmf.5
Sam Reed (2):
      * [22505f7] OATHUserRepository: Remove some legacy handling
      * [6898d6b] OATHUserRepository: Stop handling legacy single-key

[BOT] Translation updater bot (3):
      * [9606a8f] Localisation updates from https://translatewiki.net.
      * [1b6ed14] Localisation updates from https://translatewiki.net.
      * [4faabe7] Localisation updates from https://translatewiki.net.
taavi added subscribers: Reedy, taavi.Mar 30 2022, 9:03 AM

possible cause: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/773914

hashar added a comment.Mar 30 2022, 9:11 AM

Very likely, I thought there was no change introduced recently cause my local copy of OATHAuth was not up-to-date (I have amended my comment above).

Looks like we should rollback the change. Or maybe labswiki users have not been migrated?

hashar mentioned this in T304375: Remove runtime handling for "legacy" rows and codepaths.Mar 30 2022, 9:11 AM
Zabe subscribed.Mar 30 2022, 12:17 PM
gerritbot added a comment.Mar 30 2022, 12:17 PM

Change 774995 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/OATHAuth@master] Revert "OATHUserRepository: Stop handling legacy single-key"

https://gerrit.wikimedia.org/r/774995

gerritbot added a project: Patch-For-Review.Mar 30 2022, 12:17 PM
Zabe added a comment.Mar 30 2022, 12:18 PM

maybe running updateTOTPToMultipleKeys.php on labswiki does fix the issue.

gerritbot added a comment.Mar 30 2022, 12:28 PM

Change 774995 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Revert "OATHUserRepository: Stop handling legacy single-key"

https://gerrit.wikimedia.org/r/774995

gerritbot added a comment.Mar 30 2022, 12:29 PM

Change 774996 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/OATHAuth@wmf/1.39.0-wmf.5] Revert "OATHUserRepository: Stop handling legacy single-key"

https://gerrit.wikimedia.org/r/774996

Zabe added a comment.Mar 30 2022, 12:32 PM

The change is so simple that for now we can revert it. It can easily be reapplied after any missing migration has been done.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 30 2022, 1:00 PM
Krinkle assigned this task to Zabe.Mar 31 2022, 12:13 AM
Krinkle subscribed.

Thanks @Zabe. We didn't think to check labswiki. Oops :/

gerritbot added a comment.Mar 31 2022, 8:26 AM

Change 774996 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@wmf/1.39.0-wmf.5] Revert "OATHUserRepository: Stop handling legacy single-key"

https://gerrit.wikimedia.org/r/774996

Stashbot added a comment.Mar 31 2022, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T08:30:27Z] <hashar@deploy1002> Synchronized php-1.39.0-wmf.5/extensions/OATHAuth/src/OATHUserRepository.php: Backport: [[gerrit:774996|Revert "OATHUserRepository: Stop handling legacy single-key" (T305029)]] (duration: 00m 51s)

hashar renamed this task from PHP Notice: Undefined index: keys to wikitech still relies on OATHAuth legacy single-key (was PHP Notice: Undefined index: keys).Mar 31 2022, 8:41 AM
hashar lowered the priority of this task from Unbreak Now! to High.

This is no more an unbreak now since the faulty patch got rolled back. I have kept the task open to get wikitech updated and then we can reapply the change?

hashar removed a parent task: T300204: 1.39.0-wmf.5 deployment blockers.Mar 31 2022, 8:41 AM
hashar mentioned this in T300204: 1.39.0-wmf.5 deployment blockers.
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2022, 9:10 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.5; 2022-03-28); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 10:00 AM
Reedy added a comment.Apr 1 2022, 3:16 PM

It doesn't anymore!

MariaDB [labswiki]> select * from oathauth_users WHERE data NOT like "{\"keys%";
Empty set (0.001 sec)
Reedy closed this task as Resolved.Apr 1 2022, 3:23 PM
Reedy added a comment.Apr 1 2022, 3:30 PM
In T305029#7824852, @Reedy wrote:

It doesn't anymore!

MariaDB [labswiki]> select * from oathauth_users WHERE data NOT like "{\"keys%";
Empty set (0.001 sec)

And neither does labtestwiki. Patch should be good to be rolled forward again

Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Apr 7 2022, 3:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL