Page MenuHomePhabricator

An incomplete new Vector appearance is served when invalid 'useskin' query param is used
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
An incomplete new Vector appearance is served, especially the sidebar and language selector.

What should have happened instead?:
Fallback to the site's default skin, Vector 2022 for the beta cluster, and the appearance are complete.

  • QA steps ***

A screenshot of https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page should be identical to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskin=foo

QA Results - Prod

ACStatusDetails
1T305232#7847005

Event Timeline

With bad query string parameter:

Screen Shot 2022-04-01 at 8.36.40 AM.png (1×2 px, 736 KB)

With good query string parameter:

Screen Shot 2022-04-01 at 8.36.56 AM.png (1×2 px, 807 KB)

Can replicate locally, have a theory about what's happening here.

Change 776226 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Drop the LatestSkinVersionRequirement

https://gerrit.wikimedia.org/r/776226

Change 776226 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Drop the LatestSkinVersionRequirement

https://gerrit.wikimedia.org/r/776226

Edtadros subscribed.

Test Result - Prod

Status:
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.org/wiki/Main_Page
Visit https://en.wikipedia.org/wiki/Main_Page?useskin=foo
Compare the difference in appearance.
What happens?:
❓ AC1: Fallback to the site's default skin, Vector legacy for prod, and the appearance are complete.
This reverted to Vector legacy even though my selected skin in preferences/appearance was 2022.

Screen Recording 2022-04-11 at 6.16.40 PM.mov.gif (680×1 px, 1 MB)

@Jdlrobson, I'm not moving this into Ready for Signoff because I'm not sure how valid the test in Prod is since the default skin is not Legacy 2022. If you're good with it, let me know.

That LGTM. When foo is given it doesn't match a skin so we fall back to the default skin for this wiki which in this case is legacy.