Page MenuHomePhabricator

ParseError: syntax error, unexpected '<<' (T_SL)
Closed, ResolvedPublicSecurity

Description

Error
normalized_message
[{reqId}] {exception_url}   ParseError: syntax error, unexpected '<<' (T_SL)
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.6/includes/specials/SpecialWhatLinksHere.php(194)
#0 [internal function]: AutoLoader::autoload(string)
#1 /srv/mediawiki/php-1.39.0-wmf.6/vendor/wikimedia/object-factory/src/ObjectFactory.php(247): spl_autoload_call(string)
#2 /srv/mediawiki/php-1.39.0-wmf.6/vendor/wikimedia/object-factory/src/ObjectFactory.php(152): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(array, array)
#3 /srv/mediawiki/php-1.39.0-wmf.6/includes/specialpage/SpecialPageFactory.php(1234): Wikimedia\ObjectFactory\ObjectFactory->createObject(array, array)
#4 /srv/mediawiki/php-1.39.0-wmf.6/includes/MediaWiki.php(274): MediaWiki\SpecialPage\SpecialPageFactory->getPage(string)
#5 /srv/mediawiki/php-1.39.0-wmf.6/includes/MediaWiki.php(911): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.39.0-wmf.6/includes/MediaWiki.php(565): MediaWiki->main()
#7 /srv/mediawiki/php-1.39.0-wmf.6/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.39.0-wmf.6/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}
Impact
Notes

Potentially related to: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/775993

Details

Risk Rating
Low
Author Affiliation
Wikimedia Communities
Request URL
https://www.mediawiki.org/wiki/Special:WhatLinksHere/Project:Help

Event Timeline

jnuche triaged this task as Unbreak Now! priority.Apr 5 2022, 9:29 AM
jnuche created this task.
taavi lowered the priority of this task from Unbreak Now! to Needs Triage.Apr 5 2022, 9:32 AM
taavi set Security to Software security bug.
taavi added projects: Security, Security-Team.
taavi changed the visibility from "Public (No Login Required)" to "Custom Policy".
taavi changed the subtype of this task from "Production Error" to "Security Issue".
taavi added a subscriber: taavi.

caused by a merge conflict in a security patch

taavi triaged this task as Unbreak Now! priority.Apr 5 2022, 9:32 AM
hashar added a subscriber: hashar.

@jnuche and I talked about it. The issue is due to security patches for T297754 which got merged on April 1st, we will remove them after lunch and cleanup the /srv/mediawiki-staging/php-1.39.0-wmf.6 area.

Please do not act since we need @jnuche to be familiar with that process and he will handle it :]

A follow up action is find out why stage-train or scap apply-patches --train 1.39.0-wmf.6 fail to notice the conflict.

A follow up action is find out why stage-train or scap apply-patches --train 1.39.0-wmf.6 fail to notice the conflict.

That is a bug in stage-train which was not checking the exit code of the commands until https://gerrit.wikimedia.org/r/c/mediawiki/tools/release/+/773328

Jaime used a previous version of the script which ignores the command status and thus the script kept processing despite the patches failing to apply.

Fixed merge conflicts, reapplied security patches and promoted to group0 again. The error is now gone from the logs.

sbassett added a project: SecTeam-Processed.
sbassett changed Author Affiliation from N/A to Wikimedia Communities.
sbassett changed the visibility from "Custom Policy" to "Public (No Login Required)".
sbassett changed Risk Rating from N/A to Low.