Page MenuHomePhabricator
Create Task
Maniphest T305212

1.39.0-wmf.6 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.39.0-wmf.6
Release Date
Apr 4 2022, 12:00 AM

2022 week 14 1.39-wmf.6 Changes wmf/1.39.0-wmf.6

This MediaWiki Train Deployment is scheduled for the week of Monday, April 4th:

Monday April 4thTuesday, April 5thWednesday, April 6thThursday, April 7thFriday
Backports only.Branch wmf.6 and deploy to Group 0 Wikis.Deploy wmf.6 to Group 1 Wikis.Deploy wmf.6 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.6 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.39.0-wmf.5
Next: 1.39.0-wmf.7

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedRelease• jnucheT305212 1.39.0-wmf.6 deployment blockers
 ResolvedSecurityNoneT305440 ParseError: syntax error, unexpected '<<' (T_SL)

Event Timeline

thcipriani created this task.Apr 1 2022, 12:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2022, 12:51 AM
thcipriani assigned this task to • jnuche.Apr 1 2022, 12:52 AM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Doing).
hashar subscribed.Apr 4 2022, 6:26 PM
gerritbot added a comment.Apr 5 2022, 7:37 AM

Change 777294 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777294

gerritbot added a project: Patch-For-Review.Apr 5 2022, 7:37 AM

Change 777294 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777294

Stashbot added a comment.Apr 5 2022, 7:38 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T07:38:27Z] <jnuche@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.6 refs T305212

Stashbot added a comment.Apr 5 2022, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T08:21:21Z] <jnuche@deploy1002> Finished scap: testwikis wikis to 1.39.0-wmf.6 refs T305212 (duration: 42m 53s)

gerritbot added a comment.Apr 5 2022, 8:26 AM

Change 777299 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777299

gerritbot added a comment.Apr 5 2022, 8:26 AM

Change 777299 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777299

Stashbot added a comment.Apr 5 2022, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T08:31:23Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.39.0-wmf.6 refs T305212

Stashbot added a comment.Apr 5 2022, 11:45 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T11:45:30Z] <jnuche@deploy1002> Started scap: resync wmf.6 to reapply security patches - T305212

Stashbot added a comment.Apr 5 2022, 11:48 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T11:48:21Z] <jnuche@deploy1002> Finished scap: resync wmf.6 to reapply security patches - T305212 (duration: 02m 50s)

gerritbot added a comment.Apr 5 2022, 11:49 AM

Change 777344 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777344

gerritbot added a comment.Apr 5 2022, 11:50 AM

Change 777344 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777344

Stashbot added a comment.Apr 5 2022, 11:52 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T11:52:10Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.39.0-wmf.6 refs T305212

• jnuche closed subtask T305440: ParseError: syntax error, unexpected '<<' (T_SL) as Resolved.Apr 5 2022, 12:10 PM
gerritbot added a comment.Apr 6 2022, 8:37 AM

Change 777748 had a related patch set uploaded (by Jaime Nuche; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777748

gerritbot added a comment.Apr 6 2022, 8:38 AM

Change 777748 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/777748

Jdlrobson added subscribers: • eigyan, Jdlrobson.EditedApr 6 2022, 10:03 PM

Hi there @jnuche! We have an issue with wmf5 (T305171) that we'd rather not be present going into the weekend. If the train runs as expected tomorrow, then we don't have a problem.

In the event that the train gets rolled back or stalled for whatever reason, could you please backport https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/+/777775 ?

cc @eigyan

• eigyan added a comment.Apr 6 2022, 10:11 PM

@Jdlrobson, thank you for helping me sort a path forward with this patch deployment -> much appreciated!

Jdlrobson mentioned this in T305171: Convert performanceNow datatype to Integer in QuickSurvey Initiation.Apr 6 2022, 10:11 PM
ssastry added a subtask: T305597: Spaces before a colon in a preformatted block replaced with random other letters.Apr 7 2022, 5:58 AM
ssastry subscribed.

Please hold off deploying to group 2 till I have verified that T305597 isn't a problem because this looks suspiciously related to a fix for T277415 - https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/768281/.

ssastry added a comment.Apr 7 2022, 7:00 AM

I established that the bug predates the new parsoid release. So, I am going to remove it as a blocker and we'll debug and fix it separately.

ssastry removed a subtask: T305597: Spaces before a colon in a preformatted block replaced with random other letters.Apr 7 2022, 7:00 AM
ssastry added a subtask: T305597: Spaces before a colon in a preformatted block replaced with random other letters.Apr 7 2022, 7:16 AM

Sorry about the flip flop, but there is one other piece of the mystery that we need to resolve. Why is this bug now triggering on unedited parts of the page during this train?

ssastry added a comment.EditedApr 7 2022, 7:44 AM

Deleted comment -- meant to post on the other task.

ssastry removed a subtask: T305597: Spaces before a colon in a preformatted block replaced with random other letters.Apr 7 2022, 7:51 AM
ssastry added a comment.Apr 7 2022, 7:53 AM

Please look at T305597 for details, but I have verified that this issue doesn't impact non-private wikis, and even on private wikis, the dirtying seems limited to "whitespace before colons that are themselves embedded in preformatted blocks". The dirtying is not more widespread on officewiki or wikitech. I suppose if it were, we would have heard by now.

I still don't know what is causing this. But, given the limited impact, I think the train can go ahead and we'll investigate that separately. We also already have a fix for the bug itself and so on the next train, this specific issue should be resolved.

hashar removed a subtask: T305531: Several messages on Wikidata now show <translate> tags.Apr 7 2022, 8:08 AM
gerritbot added a comment.Apr 7 2022, 8:10 AM

Change 778217 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/778217

gerritbot added a comment.Apr 7 2022, 8:11 AM

Change 778217 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.6 refs T305212

https://gerrit.wikimedia.org/r/778217

Stashbot added a comment.Apr 7 2022, 8:13 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-07T08:13:00Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.39.0-wmf.6 refs T305212

hashar added a comment.Apr 7 2022, 9:04 AM

Now new MediaWiki log errors so far. It is rather quiet!

hashar closed this task as Resolved.Apr 7 2022, 12:40 PM

Looks like it is stable \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits