Page MenuHomePhabricator
Create Task
Maniphest T306264

MOBILE FUNCTION EDITOR: footer buttons
Closed, DeclinedPublic
Actions

Description

When in mobile, there should be two buttons at the bottom of the page:

  1. DONE
  2. gray state when the button is invalid (see desktop version for validity parameters)
  3. normal state when the button is valid
  4. on click: confirmation dialog (see T306265) and
    • if "DONE" selected, go to to view function
    • if "CANCEL" selected, close dialog
  1. Implement function
  2. gray state when the button is invalid (same validity parameters as done)
  3. primary state when the button is valid
  4. on click: confirmation dialog (see T306265) and
    • if "DONE" selected, go to implementation page (NOTE: there are no mobile mocks for implementation page yet)
    • if "CANCEL" selected, close dialog

figma link: https://www.figma.com/file/z4PDWdNVvwEtRMMozW8Fvi/Function-editor?node-id=1686%3A7760

Related Objects
Search...

Event Timeline

• JKieserman created this task.Apr 15 2022, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2022, 4:51 PM
• JKieserman mentioned this in T306265: MOBILE FUNCTION EDITOR: confirmation dialog.Apr 15 2022, 4:52 PM
• JKieserman updated the task description. (Show Details)
Jdforrester-WMF moved this task from Incoming to Ready: G4. Function view on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 19 2022, 4:31 PM
Jdforrester-WMF added a parent task: T306450: Adjust the function editor to be mobile-friendly as well.Apr 19 2022, 4:56 PM
• JKieserman claimed this task.May 3 2022, 7:20 AM
• JKieserman reassigned this task from • JKieserman to • AdesojiThisDot.Aug 8 2022, 2:01 PM
• JKieserman updated the task description. (Show Details)Aug 15 2022, 1:39 PM
• JKieserman claimed this task.Aug 16 2022, 1:14 PM
• JKieserman added a subscriber: • AdesojiThisDot.
• JKieserman added a subscriber: • amin.EditedAug 22 2022, 1:10 PM

I want to run through this quickly with @aminalhazwani before implementing - will do that next week when he returns from vacation.

• JKieserman added a subscriber: AAlhazwani-WMF.Aug 22 2022, 1:12 PM
MShilova_WMF removed • JKieserman as the assignee of this task.Aug 22 2022, 1:40 PM
MShilova_WMF changed the task status from Open to Stalled.Aug 22 2022, 3:15 PM
AAlhazwani-WMF updated the task description. (Show Details)Aug 29 2022, 4:47 PM
AAlhazwani-WMF removed a subscriber: • amin.
AAlhazwani-WMF added a project: Design.Aug 31 2022, 7:29 AM
gengh changed the task status from Stalled to Open.Sep 6 2022, 2:26 PM
• JKieserman claimed this task.Sep 7 2022, 1:09 PM
• JKieserman added a comment.Sep 9 2022, 12:14 PM

Chatted with Amin and we concluded that having a different workflow between desktop and mobile for submitting an edit to a function doesn't quite make sense here. Particularly,

  1. We don't need to have different copy between desktop and mobile versions ("Done" vs. "Implement function")
  2. Having two different flows (pop-up on cancel vs. pop-up on save) could be confusing for users
  3. Having different redirections (back to the function page vs. to creating a new implementation) could be confusing for users.

Given that, I'd propose we mark this ticket as declined/invalid.

• JKieserman moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Sep 9 2022, 12:15 PM
AAlhazwani-WMF added a comment.Sep 12 2022, 9:07 AM

+1 to marking this as declined/invalid.

gengh closed this task as Declined.Sep 12 2022, 1:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL