Page MenuHomePhabricator

Unify deletion success message when the subject and talk page are deleted together
Closed, ResolvedPublic2 Estimated Story Points

Description

From gerrit suggested by @Tacsipacsi in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741717/comment/5dc107d3_0074c70a/

The log link now appears twice:

"Foo" has been deleted. See deletion log for a record of recent deletions.
"Talk:Foo" has been deleted. See deletion log for a record of recent deletions.

It’d be nicer to show it only once, for example:

"Foo" and "Talk:Foo" have been deleted. See deletion log for a record of recent deletions.

Doing so would require retranslation, but I think it’s still worth it.


For Undelete, there is currently no mention of the associated talk page if it was successfully restored

Event Timeline

I was referring to the message appearing on the action=delete page, not the actual logs. Logging two deletions with two log entries is totally okay and actually better (logs are connected to page titles, so if there was only one log message, either the talk page or the content page didn’t have a log message, which would be very confusing).

I was referring to the message appearing on the action=delete page, not the actual logs. Logging two deletions with two log entries is totally okay and actually better (logs are connected to page titles, so if there was only one log message, either the talk page or the content page didn’t have a log message, which would be very confusing).

Thanks for clarifying. Miss-understood what you said

dmaza renamed this task from Unify (un)deletion logs when the subject and talk page are (un)deleted together to Unify (un)deletion success message when the subject and talk page are (un)deleted together.Apr 20 2022, 7:16 PM
dmaza updated the task description. (Show Details)

Change 822751 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/core@master] DeleteAction: Improve messaging on successful page deletion

https://gerrit.wikimedia.org/r/822751

dmaza renamed this task from Unify (un)deletion success message when the subject and talk page are (un)deleted together to Unify deletion success message when the subject and talk page are deleted together.Aug 15 2022, 4:34 AM

Noting that deleting a file is a separate process and it currently does not show any messaging when the talk page is also deleted. This patch doesn't change how File Deletion or Undeletion show their messaging on success.

Change 822751 merged by jenkins-bot:

[mediawiki/core@master] DeleteAction: Improve messaging on successful page deletion

https://gerrit.wikimedia.org/r/822751

I have tested a few different cases on beta.

"Large" refers to pages with over 1000 revisions. There is a different message when deleting small vs. large pages. For the former we use the deletedtext message. For the latter we use delete-scheduled.

We only unify when both content and talk page are small.

We don't unify message when deleting files or when restoring/undeleting pages.

@NRodriguez @dmaza What is the scope of this ticket we want? Should I raise additional bugs on unifying the message for deleting large pages, files and restoring?

CaseMessageExample
Both content and talk page smalldeleted-page-and-talkpage
both_small.png (218Γ—959 px, 29 KB)
Content small, talk page largedeletedtext (for the content page) and delete-scheduled (for the talk page)
content_small_talk_big.png (739Γ—1 px, 123 KB)
Content large, talk page smalldeletedtext (for the talk page) and delete-scheduled (for the content page)
content_big_talk_small.png (679Γ—996 px, 113 KB)
Both content and talk page largedelete-scheduled and delete-scheduled
both_big.png (241Γ—993 px, 28 KB)
Restoring content and talk pageMessage only for content page
restore_both_small.png (273Γ—723 px, 23 KB)
Deleting file content and talk pageMessage only for content page
delete_file.png (282Γ—743 px, 28 KB)

Note, enwiki beta has a custom message for deletedtext, hence why it looks different in the screenshots above. Users can also define a custom message on wiki for the newly created deleted-page-and-talkpage message (by editing https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Deleted-page-and-talkpage).