https://en.wikipedia.org/?diff=1084558271
This looks the same as T280050, which was fixed a year ago. There's also a vaguely related task T280603.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Bump wikimedia/parsoid to 0.16.0-a9 | mediawiki/vendor | master | +144 -142 | |
| Improve robustness of tagging misnested link-in-link content | mediawiki/services/parsoid | master | +117 -121 |
Related Objects
Related Objects
- Mentioned In
- T310220: After encountering a wikilink-in-extlink, Parsoid incorrectly marks subsequent unrelated fragments (in its DOM subtree) misnested
- Mentioned Here
- T280050: Broken link wikitext leads to content duplication
T280603: html2wt: Be careful about separate reuse from original source in link (and other) misnesting scenarios
Event Timeline
Comment Actions
This below demonstrates the problem
[subbu@earth:~/work/wmf/parsoid] echo "[http://foo.com [[Foo]]]" | php bin/parse.php
<p data-parsoid='{"dsr":[0,24,0,0]}'><a rel="mw:ExtLink" href="http://foo.com" class="external autonumber" data-parsoid='{"dsr":[0,24,16,1]}'></a><a rel="mw:WikiLink" href="./Foo" title="Foo" class="mw-redirect" data-parsoid='{"stx":"simple","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[24,24,null,null],"misnested":true}'>Foo</a></p>
[subbu@earth:~/work/wmf/parsoid] echo "[http://foo.com ''[[Foo]]'']" | php bin/parse.php
<p data-parsoid='{"dsr":[0,28,0,0]}'><a rel="mw:ExtLink" href="http://foo.com" class="external text" data-parsoid='{"dsr":[0,28,16,1]}'><i data-parsoid='{"dsr":[16,27,2,2]}'></i></a><i data-parsoid='{"dsr":[16,27,2,2]}'><a rel="mw:WikiLink" href="./Foo" title="Foo" class="mw-redirect" data-parsoid='{"stx":"simple","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[28,28,null,null],"misnested":true}'>Foo</a></i></p>UnpackDOMFragments marks the broken content with 'misnested: true' properties but it isn't robust enough. So, need to update it to mark the outermost / all nodes of the subtree as misnested, not just the a-tag.
Comment Actions
Change 790422 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Make marking of misnested link-in-link content more robust
Comment Actions
Change 790422 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Improve robustness of tagging misnested link-in-link content
Comment Actions
It is, but some of our phabricator processes on the team are changing a bit. For now, till this is deployed and verified working, let us leave this open.
Comment Actions
Change 797372 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a9
Comment Actions
Change 797372 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a9