enwikinews: FlaggedRev hook triggers: Error: Class 'GoogleNewsSitemap' not found
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	May 4 2022, 9:19 AM

Description

Error

mwversion: 1.39.0-wmf.10
reqId: 167f19a2-afac-4356-b21d-90ac0b117869
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Class 'GoogleNewsSitemap' not found

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.10/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(1348)
#0 /srv/mediawiki/php-1.39.0-wmf.10/includes/HookContainer/HookContainer.php(338): FlaggedRevsHooks::gnsmQueryModifier(array, array, array, array)
#1 /srv/mediawiki/php-1.39.0-wmf.10/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.39.0-wmf.10/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(340): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.39.0-wmf.10/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(145): MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap->getCategories(array, array, array)
#4 /srv/mediawiki/php-1.39.0-wmf.10/includes/specialpage/SpecialPage.php(688): MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap->execute(NULL)
#5 /srv/mediawiki/php-1.39.0-wmf.10/includes/specialpage/SpecialPageFactory.php(1409): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.39.0-wmf.10/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.39.0-wmf.10/includes/MediaWiki.php(912): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.39.0-wmf.10/includes/MediaWiki.php(566): MediaWiki->main()
#9 /srv/mediawiki/php-1.39.0-wmf.10/index.php(50): MediaWiki->run()
#10 /srv/mediawiki/php-1.39.0-wmf.10/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Impact

Notes

Details

Request URL: https://en.wikinews.org/w/index.php?title=*&feed=*&categories=*&notcategories=*&namespace=*&count=*&ordermethod=*&stablepages=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
FlaggedRevsHooks: Update use of GoogleNewsSitemap constants	mediawiki/extensions/FlaggedRevs	wmf/1.39.0-wmf.10	+3 -0
phan: Properly use actual GoogleNewsSitemap, not a stub	mediawiki/extensions/FlaggedRevs	master	+2 -9
FlaggedRevsHooks: Update use of GoogleNewsSitemap constants	mediawiki/extensions/FlaggedRevs	master	+3 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T305216 1.39.0-wmf.10 deployment blockers
		Resolved	PRODUCTION ERROR	Jdforrester-WMF	T307552 enwikinews: FlaggedRev hook triggers: Error: Class 'GoogleNewsSitemap' not found

Event Timeline

hashar created this task.May 4 2022, 9:19 AM

hashar triaged this task as Unbreak Now! priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2022, 9:19 AM

Most probably caused by bc60820a8839c02ddab01c3517f88bc809040638 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GoogleNewsSitemap/+/778533

That can be found via: https://codesearch.wmcloud.org/search/?q=GoogleNewsSitemap&i=nope&files=&excludeFiles=&repos=Extension:FlaggedRevs

The issue was not caught on CI by Phan cause there is a stub file:

.phan/stubs/googlenewssitemap.php

<?php

class GoogleNewsSitemap {
	public const OPT_INCLUDE = 0;
	public const OPT_ONLY = 1;

Which should be addressed, we need the Phan job triggering for FlaggedRevs to inject the GoogleNewsSitemap extension (which can be done in integration/config by adding the dependency to zuul/parameter_functions.py under the dict phan_dependencies).

In T307552#7902402, @hashar wrote:

we need the Phan job triggering for FlaggedRevs to inject the GoogleNewsSitemap extension (which can be done in integration/config by adding the dependency to zuul/parameter_functions.py under the dict phan_dependencies).

That's already set (done in rCICFe8f52636e431: [FlaggedRevs] Add phan dependencies), it's just that the stub was over-riding.

Edit: Ah, because rEFLR501a88dc8feb: Add Phan stub for GoogleNewsSitemap extension removed it. :-(

Change 789122 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@master] phan: Properly use actual GoogleNewsSitemap, not a stub

https://gerrit.wikimedia.org/r/789122

gerritbot added a project: Patch-For-Review.May 4 2022, 10:58 AM

Change 789124 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHooks: Update use of GoogleNewsSitemap constants

https://gerrit.wikimedia.org/r/789124

Change 789124 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHooks: Update use of GoogleNewsSitemap constants

https://gerrit.wikimedia.org/r/789124

Change 789122 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] phan: Properly use actual GoogleNewsSitemap, not a stub

https://gerrit.wikimedia.org/r/789122

Change 788861 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.10] FlaggedRevsHooks: Update use of GoogleNewsSitemap constants

https://gerrit.wikimedia.org/r/788861

Change 788861 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.10] FlaggedRevsHooks: Update use of GoogleNewsSitemap constants

https://gerrit.wikimedia.org/r/788861

Mentioned in SAL (#wikimedia-operations) [2022-05-04T12:38:22Z] <hashar@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/FlaggedRevs/: FlaggedRevsHooks: Update use of GoogleNewsSitemap constants - T307552 (duration: 00m 51s)

hashar closed this task as Resolved.May 4 2022, 12:51 PM

hashar assigned this task to Jdforrester-WMF.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 4 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 4 2022, 1:31 PM

Krinkle moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.Jun 23 2022, 4:05 PM

enwikinews: FlaggedRev hook triggers: Error: Class 'GoogleNewsSitemap' not foundClosed, ResolvedPublicPRODUCTION ERRORActions