Page MenuHomePhabricator
Create Task
Maniphest T308433

VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki)
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • I don't use ve so I can't reproduce

What happens?:
cs1|2 citation template gets stuff like: |volume=Vol. 1 no. 1 (diff) and |volume=Vol 13 No 3 (diff)
These malformed parameter values cause Module:Citation/CS1 (at en.wiki and at other-language wikis that use a more-or-less current version of the module suite) to emit '|volume= has extra text' error messages because the module is responsible for the static text ('Vol.', 'no.') when rendering the citation.
What should have happened instead?:
|volume=1 |issue=1 and |volume=13 |issue=3

Event Timeline

Trappist_the_monk created this task.May 16 2022, 12:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2022, 12:13 PM
Amire80 added a project: VisualEditor.May 16 2022, 1:08 PM
Esanders added a project: Citoid.May 16 2022, 1:32 PM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.May 19 2022, 3:41 PM
Mvolz subscribed.May 30 2022, 10:39 AM
This comment was removed by Mvolz.
Mvolz triaged this task as Medium priority.May 30 2022, 10:39 AM

Now having looked at the examples, these can't be from citoid because they're both pdf links which citoid doesn't do. Potentially user error?

Mvolz removed a project: Citoid.May 30 2022, 10:42 AM
Mvolz added a comment.May 30 2022, 10:56 AM

A potential fix could be change the template data type - currently issue and volume are both set to "line" and it could be set to "number". However if you have, for instance, a "summer" issue, then that would prevent people from using that. Other than validating it against the type, there's currently no way to validate it more specifically than that.

I've added more documentation to make it clear to the user what belongs in the field - maybe that will help?

https://en.wikipedia.org/w/index.php?title=Template:Cite_journal/doc&type=revision&diff=1090605535&oldid=1078016122&diffmode=source

Mvolz added a comment.May 30 2022, 11:06 AM

Ah, and only volume but not issue was in the suggested params - so they didn't probably notice you could add the issue separately. Fixed: https://en.wikipedia.org/w/index.php?title=Template:Cite_journal/doc&type=revision&diff=1090606937&oldid=1090605535&diffmode=source

Mvolz closed this task as Resolved.May 30 2022, 11:20 AM
Mvolz claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits