Extension:FileImporter allows us to import files to Commons even if the original uploader at the sister project is blocked on Commons. That seems to be OK in principle. However, it would be great if the importing user could be made aware of the situation, so they can take extra care when checking the file for copyright violations etc.
Description
Description
Event Timeline
Comment Actions
Hmm that's strange. FileImporter should apply the checks that are also done in the UploadBase to validate a user is not blocked[1][2]. In a first review I only see nuances where checks differ but these should not make any difference. 🤔
[1] https://gerrit.wikimedia.org/g/mediawiki/extensions/FileImporter/+/0bc834d205007ff4ee0a248339316f1231d462ba/src/SpecialImportFile.php#151
[2] https://gerrit.wikimedia.org/g/mediawiki/core/+/0957dd498faba714169386f3e171a1324dcac040/includes/api/ApiUpload.php#587
Comment Actions
Wait, it seems the import was done by another user, not the blocked one. That changes things. Apparently the user importing the file was not aware that the original uploader at the sister project was blocked at commons. I guess there should at least be a warning?
Comment Actions
Ahh right. Good call. I'm not sure if a warning is the correct way forward here. Just because a user has been blocked ( for whatever reason ) it might still be totally fine to move files to commons that have been uploaded by that user. If any of the images that the blocked user has uploaded are problematic or should not be moved to commons, that should then be solved on the source wiki. For example by marking them with a corresponding template that explicitly warns about not moving to commons.
Comment Actions
Wish I could claim that for myself, but it was pointed out by CptViraj here. Sorry for the false alarm. It seems Commons is OK with importing this kind of file in principle, but it would be good to alert the importing user about the situation.
Would it be possible for the Importer to detect this situation and just display a heads-up warning along the lines of "You're about to import a file that was uploaded by a user who is blocked on Commons. Please take some extra care to make sure it is OK"?
Comment Actions
Since this is now more moving into the direction of being a new feature request rather than a bug, it would need some product / ux input. Since our current focus lies on some other projects though I'll have to leave it for later considerations.
Comment Actions
I do not think FileImporter should prevent files by blocked users to be uploaded. But it could be a good idea to add a warning like "Hey the uploader is blocked. Are you sure you want to move the file?"
Comment Actions
I agree a warning would be useful in this context. There have been at least two sock-drawers that have taken advantage of innocent third-parties to evade commons blocks in this manner. I would even support a prohibition (not just warning) because it is evasion-by-proxy (at best) and does literally appear to be evasion in the edit-history on commons. But unlike some wikipedias, commons does not seem to take a strict stance based on the *spirit* of evasion, only the letter of "this account is blocked, so this *account* cannot itself make edits".
Edit: the "edit-history" detail is that the timestamp of the file-upload (via importer) is during the timeframe that the block is in force.