Page MenuHomePhabricator

Small, translated, SVG files do not display the "render this image in $lang" dropdown
Closed, ResolvedPublicBUG REPORT

Description

I'm seeing some multilingual SVG File: pages that do not offer to show the translated languages ("Render this image in ...").

These files are small, so they are not the SVG file greater than 256 kB issue raised in T270889.

Many of the files do not have systemLanguage="en" clauses.

List of steps to reproduce (step by step, including full links if applicable):

None of these File: pages display the render this image in language dropdown:

Here's an even odder case. Go to

They will display the language drop down box.

Now select the "(default language)" option and click GO. The language dropdown box is not present on the new page

Selecting the default language is the same as going to

Alternatively, ask for the Klingon version of the page, which does not have a render this image in (language) selector either:

What happens?:
The language dropdown box is not displayed on the File: page even though translations are present.

What should have happened instead?:
The dropdown box should display for any SVG File: page that has translations.

Apparently, the dropdown box only displays if no HTML lang parameter is given and the file has systemLanguage="en" or if an HTML lang parameter is given, then the file must have that systemLanguage.

For example, specify lang=eu for the eu-only Minsk Protocol.svg above provides a dropdown:

Event Timeline

TheDJ subscribed.

The language dropdown is rendered by ImagePage::doRenderLangOpt

Presence of the dropdown is gated on:

$this->displayImg->getAvailableLanguages();
			if ( $renderLang !== null && count( $renderLangOptions ) >= 1 ) {

This likely broke in commit c259c37033d3f16aa949855d25178e76578bb586 by @Umherirrender, renderLanguage is allowed to be optional here.

Change 803985 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Repair language selector for SVGs

https://gerrit.wikimedia.org/r/803985

Change 803985 merged by jenkins-bot:

[mediawiki/core@master] Repair language selector for SVGs

https://gerrit.wikimedia.org/r/803985

TheDJ claimed this task.

Will be deployed next week

Will be deployed next week

Thank you for diagnosing and fixing this bug.

Change 803923 had a related patch set uploaded (by Umherirrender; author: TheDJ):

[mediawiki/core@REL1_38] Repair language selector for SVGs

https://gerrit.wikimedia.org/r/803923

Change 804445 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Improve ImagePage::doRenderLangOpt/File::getMatchedLanguage

https://gerrit.wikimedia.org/r/804445

Change 803923 merged by jenkins-bot:

[mediawiki/core@REL1_38] Repair language selector for SVGs

https://gerrit.wikimedia.org/r/803923

Change 804445 merged by jenkins-bot:

[mediawiki/core@master] Improve ImagePage::doRenderLangOpt/File::getMatchedLanguage

https://gerrit.wikimedia.org/r/804445