Maniphest T309549

Create end-to-end tests for the page/html and revision/html endpoints.
Closed, ResolvedPublic
Actions

Description

Mocha tests will help ensure that we don't break anything when introducing stashing logic. We can build on them later for creating tests that assert correct interaction between fetching html, transforming it, and saving it back.

Details

	Subject	Repo	Branch	Lines +/-
	Add end-to-end tests for fetching HTML	mediawiki/core	master	+145 -24
	PageHTMLHandler: Add end-to-end tests	mediawiki/core	master	+73 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T324931 Clean up open RESTBase related tickets
		In Progress		None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
		Open		None	T264669 Move VE API from RESTBase into core.
		Resolved		None	T267990 Support stashing in page/html and revision/html endpoints in MW core
		Resolved		daniel	T359426 REST: endpoints that return rendered page content should support all content models
		Resolved		daniel	T309549 Create end-to-end tests for the page/html and revision/html endpoints.

Event Timeline

daniel created this task.May 30 2022, 4:24 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 30 2022, 4:24 PM

Change 801432 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] PageHTMLHandler: Add end-to-end tests

https://gerrit.wikimedia.org/r/801432

gerritbot added a project: Patch-For-Review.May 30 2022, 9:27 PM

Change 801432 abandoned by Daniel Kinzler:

[mediawiki/core@master] PageHTMLHandler: Add end-to-end tests

Reason:

Dupe of Ib7c6f1371ef1dbc8dd68708a5bd8f7566ace14f3

https://gerrit.wikimedia.org/r/801432

Change 801431 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] PageHTMLHandler: Add end-to-end tests

https://gerrit.wikimedia.org/r/801431

DAlangi_WMF changed the task status from Open to In Progress.Jun 1 2022, 12:00 PM

DAlangi_WMF triaged this task as High priority.

DAlangi_WMF moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.

Change 801431 merged by jenkins-bot:

[mediawiki/core@master] Add end-to-end tests for fetching HTML

https://gerrit.wikimedia.org/r/801431

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 6:00 PM

DAlangi_WMF closed this task as Resolved.Jun 2 2022, 6:16 PM

DAlangi_WMF assigned this task to daniel.

daniel added a parent task: T359426: REST: endpoints that return rendered page content should support all content models.Wed, Apr 3, 12:20 PM