Page MenuHomePhabricator
Create Task
Maniphest T309577

Drop support for <figure-inline> and use <span> for inline media
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As per T251641 since DOM Spec 2.2.0, for inline media <span> is used instead of <figure-inline>. This effectively reverses some of the changes made in Spec 1.6.0

Since cxserver requests Spec 2.4.0, we can remove all references to <figure-inline>

Details

SubjectRepoBranchLines +/-
Update cxserver to 2022-07-27-070728-productionoperations/deployment-chartsmaster+1 -1
Drop support for <figure-inline> and use <span> for inline mediamediawiki/services/cxservermaster+59 -57
Customize query in gerrit

Related Objects

Event Timeline

• santhosh created this task.May 31 2022, 5:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2022, 5:44 AM
• santhosh triaged this task as Medium priority.May 31 2022, 5:44 AM
gerritbot added a comment.May 31 2022, 5:45 AM

Change 801581 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/services/cxserver@master] Drop support for <figure-inline> and use <span> for inline media

https://gerrit.wikimedia.org/r/801581

gerritbot added a project: Patch-For-Review.May 31 2022, 5:45 AM
• santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.May 31 2022, 6:46 AM
• santhosh set the point value for this task to 2.
• santhosh set Final Story Points to 2.
Pginer-WMF edited projects, added Language-Team (Language-2022-July-September); removed Language-Team (Language-2022-April-June).Jul 4 2022, 10:55 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-July-September) board.
gerritbot added a comment.Jul 8 2022, 2:51 PM

Change 801581 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Drop support for <figure-inline> and use <span> for inline media

https://gerrit.wikimedia.org/r/801581

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2022, 3:30 PM
gerritbot added a comment.Jul 26 2022, 5:55 AM

Change 817089 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2022-07-25-080850-production

https://gerrit.wikimedia.org/r/817089

gerritbot added a project: Patch-For-Review.Jul 26 2022, 5:55 AM
gerritbot added a comment.Jul 27 2022, 11:46 AM

Change 817089 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2022-07-27-070728-production

https://gerrit.wikimedia.org/r/817089

KartikMistry moved this task from In Review to Check after deployment on the Language-Team (Language-2022-July-September) board.Jul 27 2022, 11:50 AM
Stashbot added a comment.Jul 27 2022, 12:00 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-27T12:00:50Z] <kart_> Updated cxserver to 2022-07-27-070728-production (T313300, T309577, T310873, T310880)

Stashbot mentioned this in T310873: Post-creation work for blkwiki.Jul 27 2022, 12:00 PM
Stashbot mentioned this in T313300: Enable Section Translation on 9 more Wikipedias where Content Translation is available by default.
Stashbot mentioned this in T310880: Post-creation work for pcmwiki.
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 12:30 PM
Nikerabbit moved this task from Check after deployment to Done on the Language-Team (Language-2022-July-September) board.Sep 8 2022, 7:56 AM
Nikerabbit subscribed.

This seems difficult to verify.

Pginer-WMF closed this task as Resolved.Sep 22 2022, 10:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL