Page MenuHomePhabricator
Create Task
Maniphest T310053

DiscussionTools throws an exception in preferences.
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Make sure that the new topic tool in the Discussion tool is turned off by default and is not enabled in Beta.
  • Visit Special:Preferences.

What happens?: The following exceptions occur:

[7025127ad8d787356a39b016] /wiki/%ED%8A%B9%EC%88%98:%ED%99%98%EA%B2%BD%EC%84%A4%EC%A0%95 DomainException: HTMLForm::getField: no field named discussiontools-newtopictool

Backtrace:

from /var/www/wiki/w/includes/htmlform/HTMLForm.php(444)
#0 /var/www/wiki/w/includes/htmlform/HTMLFormField.php(145): HTMLForm->getField()
#1 /var/www/wiki/w/includes/htmlform/HTMLFormField.php(160): HTMLFormField->getNearestField()
#2 /var/www/wiki/w/includes/htmlform/HTMLFormField.php(277): HTMLFormField->getNearestFieldValue()
#3 /var/www/wiki/w/includes/htmlform/HTMLFormField.php(367): HTMLFormField->checkStateRecurse()
#4 /var/www/wiki/w/includes/htmlform/HTMLForm.php(2065): HTMLFormField->isDisabled()
#5 /var/www/wiki/w/includes/htmlform/HTMLForm.php(577): HTMLForm->loadFieldData()
#6 /var/www/wiki/w/includes/htmlform/HTMLForm.php(629): HTMLForm->prepareForm()
#7 /var/www/wiki/w/includes/specials/SpecialPreferences.php(121): HTMLForm->show()
#8 /var/www/wiki/w/includes/specialpage/SpecialPage.php(688): SpecialPreferences->execute()
#9 /var/www/wiki/w/includes/specialpage/SpecialPageFactory.php(1415): SpecialPage->run()
#10 /var/www/wiki/w/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#11 /var/www/wiki/w/includes/MediaWiki.php(916): MediaWiki->performRequest()
#12 /var/www/wiki/w/includes/MediaWiki.php(570): MediaWiki->main()
#13 /var/www/wiki/w/index.php(50): MediaWiki->run()
#14 /var/www/wiki/w/index.php(46): wfIndexMain()
#15 {main}

What should have happened instead?: Preferences should not cause exceptions.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: MediaWiki 1.39.0-alpha (a5ab9fb), DiscussionTools 0.0.0 (790ef19). It is presumed to have been caused by a modification that is part of e0f231b.

Details

SubjectRepoBranchLines +/-
Show createpage preference only when feature is availablemediawiki/extensions/DiscussionToolswmf/1.39.0-wmf.14+15 -15
Show createpage preference only when feature is availablemediawiki/extensions/DiscussionToolswmf/1.39.0-wmf.15+15 -15
Show createpage preference only when feature is availablemediawiki/extensions/DiscussionToolsmaster+15 -15
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedRelease• dduvallT308068 1.39.0-wmf.15 deployment blockers
 ResolvedBUG REPORTBluehill395T310053 DiscussionTools throws an exception in preferences.

Event Timeline

Bluehill395 created this task.Jun 7 2022, 9:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2022, 9:53 AM
gerritbot added a comment.Jun 7 2022, 10:03 AM

Change 803470 had a related patch set uploaded (by Bluehill395; author: Bluehill395):

[mediawiki/extensions/DiscussionTools@master] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/803470

gerritbot added a project: Patch-For-Review.Jun 7 2022, 10:03 AM
Esanders closed this task as Resolved.Jun 7 2022, 12:11 PM
Esanders claimed this task.
Esanders subscribed.

Thanks, the original task is still in QA so we can close out this follow up.

matmarex reassigned this task from Esanders to Bluehill395.Jun 7 2022, 12:45 PM
matmarex subscribed.

Thanks for noticing this, we were planning to backport the faulty patch today ahead of the config deployment to enable the new topic tool more widely (T309368), so you probably saved us and the users a lot of annoyance.

gerritbot added a comment.Jun 7 2022, 12:52 PM

Change 803470 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/803470

Bluehill395 added a comment.Jun 7 2022, 12:59 PM

It's my pleasure. I found this issue while building a wiki for testing. I guess I'll have to backport this change to wmf.15 anyway.

gerritbot added a comment.Jun 7 2022, 12:59 PM

Change 802965 had a related patch set uploaded (by Bluehill395; author: Bluehill395):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.15] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/802965

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 7 2022, 1:00 PM
gerritbot added a comment.Jun 7 2022, 2:01 PM

Change 803528 had a related patch set uploaded (by Bartosz Dziewoński; author: Bluehill395):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.14] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/803528

matmarex reopened this task as Open.Jun 7 2022, 2:06 PM
matmarex added a project: Editing-team (Kanban Board).

Scheduled for later today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20220607T2000

(@Bluehill395 I'll do your wmf.15 backport too)

matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.Jun 7 2022, 2:08 PM
Zabe triaged this task as Unbreak Now! priority.Jun 7 2022, 6:52 PM
Zabe merged a task: T310096: DomainException: HTMLForm::getField: no field named discussiontools-newtopictool.
Zabe added a parent task: T308068: 1.39.0-wmf.15 deployment blockers.
Zabe added a subscriber: • dduvall.
Zabe subscribed.Jun 7 2022, 7:15 PM
gerritbot added a comment.Jun 7 2022, 8:09 PM

Change 802965 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.15] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/802965

gerritbot added a comment.Jun 7 2022, 8:20 PM

Change 803528 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.14] Show createpage preference only when feature is available

https://gerrit.wikimedia.org/r/803528

Stashbot added a comment.Jun 7 2022, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-07T20:28:39Z] <urbanecm@deploy1002> Started scap: DiscussionTools backports + r803526 (T310053, T297990)

Stashbot mentioned this in T297990: Clarify how the "Enable quick topic adding" setting affects creating new talk pages (separate setting?).Jun 7 2022, 8:28 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 7 2022, 8:30 PM
Stashbot added a comment.Jun 7 2022, 8:53 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-07T20:53:23Z] <urbanecm@deploy1002> Finished scap: DiscussionTools backports + r803526 (T310053, T297990) (duration: 24m 43s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 7 2022, 9:00 PM
matmarex moved this task from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 7 2022, 9:07 PM
matmarex added a project: Skipped QA.
matmarex closed this task as Resolved.Jun 7 2022, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL