Page MenuHomePhabricator

Remove Vue version of GlobalWatchlist with its WVUI dependency
Closed, ResolvedPublic

Description

GlobalWatchlist currently uses WVUI, but WVUI is in maintenance mode and will be deprecated in favor of Codex in the near future.

The WVUI-based UI in GlobalWatchlist is currently behind a feature flag, and is disabled in production, so this migration doesn't affect users of GlobalWatchlist in production (until the feature flag is enabled at some point in the future).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

All WVUI components used by GlobalWatchlist now have equivalents in Codex

Codex does not have the same functionality that WVUI provided, specifically styles for toggle buttons that are active but disabled. This should wait until T305437: [Design Spike] Audit all use cases for "disabled" buttons to identify inconsistencies is resolved, or (less desirable) will need to add its own style overrides

This has been delayed for far too long. I'm going to propose dropping GlobalWatchlist from the CI gate so we can finally drop WVUI from MediaWiki without breaking everyone else's tests; it'll just be GW that's broken.

Change 912862 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GlobalWatchlist@master] Drop abandonware Vue version, unmaintained for over a year

https://gerrit.wikimedia.org/r/912862

Change 912862 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Drop abandonware Vue version, unmaintained for over a year

https://gerrit.wikimedia.org/r/912862

Volker_E renamed this task from Migrate GlobalWatchlist from WVUI to Codex to Remove Vue version of GlobalWatchlist with its WVUI dependency.Apr 27 2023, 3:51 PM
Volker_E closed this task as Resolved.
Volker_E claimed this task.
Volker_E updated the task description. (Show Details)

All WVUI components used by GlobalWatchlist now have equivalents in Codex, so in future someone could pick up the dropped Vue version of GlobalWatchlist and do a relatively straightforward migration.

Hello everyone. I'm working a lot on GlobalWatchlist in the last weeks, and meet Vue open tasks all the time, while thay can not be done until there will be someone that takes on themselves to rework this code for the Codex and to continue working in creation of Vue version. They should not be opened, but stalled, IMHO. What do you think if I create a new task, or maybe take an existing one if there is something that fits, make this task to be the start of the new work and change the status of all the Vue tasks from Open to Stalled on this subtask? It can be something like "Restart the Vue version development", for example. Is this OK?

If a specific task is blocked on a specific Vue task, then this could be a task-subtask relation.
I do not see any gain in creating some vague "Restart development" task though, which sounds non-actionable (everything and anything welcomes development).

As far as I can see, all of them depend on (at least) a new Gerrit change that mentioned above, revert this task change and evolve from there. Noone can fix details in Vue version, if Vue version is not in the repository.