Page MenuHomePhabricator
Create Task
Maniphest T310243

Deprecate WVUI in favor of Codex
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

WVUI is currently in maintenance mode, see T290051. This means no new features are added, but changes are still made and new releases done when necessary to fix bugs. This still happens sometimes, because there is still code using WVUI.

We would like to deprecate WVUI, migrate all code that uses it to Codex, and then remove WVUI completely.

After that, we would migrate non-production code from WVUI to Codex, and remove Codex from MW core, which is captured in T310244: Remove WVUI from MediaWiki core.

All of these are also blocked on T302772: Application Security Review Request : Codex, as we can't use Codex in any production code until its security review is completed.

Related, but not a blocker, is T286835: Port RelatedArticles to Codex. There is a patch to port RelatedArticles to WVUI, but it was never merged. There is now an alternative patch to port RelatedArticles to Codex instead of WVUI. That patch can be merged once the other issues on T286835 are addressed (and once the security review is done).

Also look at https://codesearch.wmcloud.org/things/?q=wvui&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Add comments to Icon component about WVUI and Codexmediawiki/extensions/MediaSearchmaster+15 -7
Deprecate use of 'wvui-search' packagemediawiki/coreREL1_39+1 -0
Deprecate use of 'wvui-search' packagemediawiki/coremaster+1 -0
Replace WVUI related code with Codexmediawiki/extensions/DarkModemaster+2 -2
SearchSatisfaction: Remove extraArgs logging for WVUImediawiki/extensions/WikimediaEventsmaster+0 -7
Deprecate use of wvui librarymediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Jun 9 2022, 12:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2022, 12:44 AM
Catrope updated the task description. (Show Details)Jun 9 2022, 12:46 AM
Catrope added subtasks: T303558: Typeahead search deployment: Use CdxTypeaheadSearch in Vector, T310241: Migrate QuickSurveys from WVUI to Codex, T300595: Migrate NearbyPages from WVUI to Codex, T310240: Remove Vue version of GlobalWatchlist with its WVUI dependency.
Catrope mentioned this in T310244: Remove WVUI from MediaWiki core.Jun 9 2022, 12:49 AM
Catrope updated the task description. (Show Details)
Catrope updated the task description. (Show Details)Jun 9 2022, 1:10 AM
Diesel_kapasule changed the status of subtask T310244: Remove WVUI from MediaWiki core from Open to In Progress.Jun 9 2022, 12:18 PM
AnneT subscribed.Jun 9 2022, 12:30 PM
ldelench_wmf subscribed.Jun 16 2022, 10:32 AM
egardner subscribed.Jul 18 2022, 6:13 PM

Can we get this task into a current or upcoming DST sprint?

Catrope mentioned this in T314082: Design System Infrastructure Capabilities Scoping.Jul 30 2022, 1:10 AM
gerritbot added a comment.Aug 17 2022, 5:43 PM

Change 824250 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Set intention for deprecating wvui library

https://gerrit.wikimedia.org/r/824250

gerritbot added a project: Patch-For-Review.Aug 17 2022, 5:43 PM
Catrope updated the task description. (Show Details)Aug 18 2022, 10:15 PM
Catrope updated the task description. (Show Details)Aug 23 2022, 6:24 PM
gerritbot added a comment.Aug 23 2022, 7:57 PM

Change 824250 merged by jenkins-bot:

[mediawiki/core@master] Deprecate use of wvui library

https://gerrit.wikimedia.org/r/824250

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 23 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2022, 8:30 PM
Jdlrobson closed subtask T300595: Migrate NearbyPages from WVUI to Codex as Resolved.Aug 29 2022, 10:05 PM
• DAbad edited projects, added Design-System-Team (Design-System-Product-Roadmap); removed Design-System-Team.Sep 1 2022, 3:19 PM
• DAbad changed the status of subtask T310241: Migrate QuickSurveys from WVUI to Codex from Open to In Progress.Sep 1 2022, 3:23 PM
• DAbad moved this task from Now to Planned Components on the Design-System-Team (Design-System-Product-Roadmap) board.Sep 1 2022, 3:36 PM
• DAbad subscribed.

Marking this to review for integration into roadmap

ldelench_wmf closed subtask T303558: Typeahead search deployment: Use CdxTypeaheadSearch in Vector as Resolved.Sep 9 2022, 6:23 PM
ldelench_wmf closed subtask T310241: Migrate QuickSurveys from WVUI to Codex as Resolved.
Volker_E updated the task description. (Show Details)Sep 9 2022, 7:41 PM
Volker_E updated the task description. (Show Details)
Volker_E subscribed.Sep 9 2022, 8:01 PM

A non-Wikimedia skin named Cosmos (repo) has been also making use of WVUI.

Volker_E mentioned this in T276808: Document best practices on how to add or update icons in WVUI.Sep 9 2022, 8:32 PM
Volker_E mentioned this in T284782: Improve the way WVUI ships type definitions.
Volker_E mentioned this in T269601: Integrate (and reorganize) README.md into Storybook.
gerritbot added a comment.Sep 9 2022, 9:13 PM

Change 831148 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikimediaEvents@master] [WIP] Replace WVUI by Codex

https://gerrit.wikimedia.org/r/831148

gerritbot added a project: Patch-For-Review.Sep 9 2022, 9:13 PM
Volker_E mentioned this in T291416: Determine contribution process for existing Vue.js library code.Sep 9 2022, 10:56 PM
Volker_E mentioned this in T286472: WVUI: demo code for using WVUI in user JS or gadgets.Sep 9 2022, 10:59 PM
Volker_E mentioned this in T275914: Using WVUI via ResourceLoader should expose icons.Sep 9 2022, 11:07 PM
Volker_E mentioned this in T289865: Two versions of WVUI loaded .Sep 9 2022, 11:14 PM
Volker_E mentioned this in T289989: Add loading spinner component.Sep 10 2022, 5:06 AM
Volker_E mentioned this in T317715: SearchSatisfaction schema has dead code for logging WMVI in extraParams event - should it be fixed or removed?.Sep 13 2022, 11:27 PM
Volker_E mentioned this in T143741: Search failures are not handled well by Codex TypeaheadSearch and MobileFrontend search.Sep 14 2022, 4:58 PM
Volker_E mentioned this in T305430: [WF6] wvui 0.4.0 crashes the search function for wikis not installed in /w directory.
Volker_E mentioned this in T303013: Indicate when search results are from redirects (sometimes).Sep 14 2022, 8:35 PM
Volker_E mentioned this in T275251: New Vector Search is not Wikidata aware.Sep 14 2022, 9:05 PM
Volker_E mentioned this in T261323: Add CSSJanus support.Sep 14 2022, 9:08 PM
Volker_E mentioned this in T282480: [ Eng spike] Consider adding a loading state to the typeahead-search component for loading search results.Sep 14 2022, 9:20 PM
egardner triaged this task as High priority.Sep 15 2022, 7:52 PM
gerritbot added a comment.Sep 21 2022, 8:26 AM

Change 831148 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] SearchSatisfaction: Remove extraArgs logging for WVUI

https://gerrit.wikimedia.org/r/831148

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2022, 8:31 AM
• DAbad mentioned this in T317361: [EPIC] DST Roadshow Documentation.Sep 27 2022, 5:16 PM
Volker_E updated the task description. (Show Details)Oct 3 2022, 7:38 PM
gerritbot added a comment.Oct 3 2022, 8:38 PM

Change 837746 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Deprecate use of 'wvui-search' package

https://gerrit.wikimedia.org/r/837746

gerritbot added a project: Patch-For-Review.Oct 3 2022, 8:38 PM
Volker_E mentioned this in T319239: Replace WVUI code with Codex .Oct 3 2022, 8:39 PM
gerritbot added a comment.Oct 3 2022, 8:49 PM

Change 837747 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/DarkMode@master] Replace WVUI related code with Codex

https://gerrit.wikimedia.org/r/837747

Volker_E updated the task description. (Show Details)EditedOct 3 2022, 8:56 PM

With clarification on two latest patches, this task can be resolved successfully.

GlobalWatchlist can be migrated whenever needed in future, as WVUI code is not active. Filed two tasks for skins (Cosmos, Snap!WikiSkin) relying on 'wvui-search' package. Both skins haven't seen any activity though in last year.

ldelench_wmf edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team (Design-System-Product-Roadmap).Oct 3 2022, 9:38 PM
ldelench_wmf moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.Oct 3 2022, 9:41 PM
ldelench_wmf set the point value for this task to 3.

Pushing to code review; seeking @Catrope's input on decision to move GlobalWatchlist migration out-of-scope for this task.

gerritbot added a comment.Oct 3 2022, 10:05 PM

Change 837747 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Replace WVUI related code with Codex

https://gerrit.wikimedia.org/r/837747

Volker_E mentioned this in rEDKM8b844c89d35d: Replace WVUI related code with Codex.Oct 3 2022, 10:40 PM
gerritbot added a comment.Oct 3 2022, 11:11 PM

Change 837746 merged by jenkins-bot:

[mediawiki/core@master] Deprecate use of 'wvui-search' package

https://gerrit.wikimedia.org/r/837746

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2022, 11:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Oct 4 2022, 12:00 AM
Volker_E updated the task description. (Show Details)Oct 4 2022, 3:06 AM

@Catrope My plan would be to resolve this task now with the two additional patches merged, untangle the remove task T310244 from here and leave only that on our radar.

Catrope removed a subtask: T310240: Remove Vue version of GlobalWatchlist with its WVUI dependency.Oct 4 2022, 5:56 PM
Catrope removed a subtask: T310244: Remove WVUI from MediaWiki core.
Catrope updated the task description. (Show Details)
Catrope removed a subtask: T300595: Migrate NearbyPages from WVUI to Codex.Oct 4 2022, 5:59 PM
Catrope moved this task from Code Review to Product Sign-Off on the Design-System-Team (Design-System-Sprint) board.
In T310243#8281852, @Volker_E wrote:

@Catrope My plan would be to resolve this task now with the two additional patches merged, untangle the remove task T310244 from here and leave only that on our radar.

Untangling done, T310244 is now its own task, and all the tasks about migrating non-production code have been moved to under T310244. This task is now done.

gerritbot added a comment.Oct 4 2022, 8:31 PM

Change 838262 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/extensions/MediaSearch@master] Add comments to Icon component about WVUI and Codex

https://gerrit.wikimedia.org/r/838262

gerritbot added a project: Patch-For-Review.Oct 4 2022, 8:31 PM
gerritbot added a comment.Oct 5 2022, 2:12 PM

Change 838813 had a related patch set uploaded (by Jforrester; author: VolkerE):

[mediawiki/core@REL1_39] Deprecate use of 'wvui-search' package

https://gerrit.wikimedia.org/r/838813

gerritbot added a comment.Oct 5 2022, 2:23 PM

Change 838813 merged by jenkins-bot:

[mediawiki/core@REL1_39] Deprecate use of 'wvui-search' package

https://gerrit.wikimedia.org/r/838813

ReleaseTaggerBot edited projects, added MW-1.39-notes; removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Oct 5 2022, 3:00 PM
gerritbot added a comment.Oct 6 2022, 6:39 PM

Change 838262 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Add comments to Icon component about WVUI and Codex

https://gerrit.wikimedia.org/r/838262

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.5; 2022-10-10); removed MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Oct 6 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 7:31 PM
Catrope closed this task as Resolved.Nov 23 2022, 8:01 PM
Catrope claimed this task.
Volker_E added a comment.EditedDec 31 2022, 3:09 AM

For completion, volunteer snapwikiskin has also just replaced WVUI with Codex.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits