Maniphest T310444

Standardise type for timestamp columns in SecurePoll extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jun 12 2022, 7:43 PM

Tags

Referenced Files

None

Subscribers

Description

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.

Affected columns:
securepoll_elections.el_start_date
securepoll_elections.el_end_date
securepoll_votes.vote_timestamp
securepoll_strike.st_timestamp
securepoll_cookie_match.cm_timestamp

Details

	Subject	Repo	Branch	Lines +/-
	Standardise type for timestamp columns	mediawiki/extensions/SecurePoll	master	+43 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ladsgroup	T191231 RFC: Abstract schemas and schema changes
		Open		None	T259374 Convert extensions to using abstract schema
		Resolved		None	T261912 Convert WMF Deployed Extensions to Abstract Schema
		Resolved		STran	T268572 Convert SecurePoll to AbstractSchema
		Resolved		Umherirrender	T310444 Standardise type for timestamp columns in SecurePoll extension

Event Timeline

Umherirrender created this task.Jun 12 2022, 7:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2022, 7:43 PM

Umherirrender triaged this task as Low priority.Jun 12 2022, 7:43 PM

Change 804771 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SecurePoll@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/804771

gerritbot added a project: Patch-For-Review.Jun 12 2022, 7:59 PM

Umherirrender added a parent task: T268572: Convert SecurePoll to AbstractSchema.Jun 12 2022, 8:59 PM

jrbs moved this task from Backlog to Future WMF Election Requests on the MediaWiki-extensions-SecurePoll board.Jun 17 2022, 4:53 PM

Zabe moved this task from Unsorted to Change on the Schema-change board.Jul 5 2022, 10:14 PM

Change 804771 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/804771

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 6:30 PM

Umherirrender closed this task as Resolved.Jul 13 2022, 6:36 PM

Umherirrender mentioned this in T312979: Adjust the field type of securepoll_cookie_match.cm_timestamp to fixed binary on wmf wikis.Jul 13 2022, 6:56 PM

Umherirrender mentioned this in T312980: Adjust the field type of securepoll_elections.el_start_date/el_end_date to fixed binary on wmf wikis.

Umherirrender mentioned this in T312981: Adjust the field type of securepoll_strike.st_timestamp to fixed binary on wmf wikis.

Umherirrender mentioned this in T312982: Adjust the field type of securepoll_votes.vote_timestamp timestamps to fixed binary on wmf wikis.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 13 2022, 7:00 PM