Remove Table of Contents feature flag
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Having the old table of contents code around is adding unnecessary complications for our layout changes regarding CSS grid and the article toolbar. We should remove that code. Note it will still be able to run an A/B test for table of contents feature once this code has disappeared.

Background

Sign off step for T309683

Original task that built feature flag T297610

Before beginning this ticket

Ensure data is analyzed and no additional A/B testing will be required

Acceptance criteria

Feature flag for table of contents is removed
Configuration for TOC feature flag is removed
Preserve TOC A/B test code << tracked in T313435
Update Vector to not load the legacy table of contents styles via ResourceLoaderSkinModule (toc: false)

Details

Subject	Repo	Branch	Lines +/-
Update name of body class to avoid confusion	mediawiki/skins/Vector	master	+6 -6
Remove Table of Contents config	operations/mediawiki-config	master	+0 -10
Remove Table of Contents feature flag	mediawiki/skins/Vector	master	+69 -440

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T273473 [Epic] Improve the table of contents
		Resolved		Jdlrobson	T310527 Remove Table of Contents feature flag

Event Timeline

cjming created this task.Jun 13 2022, 4:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2022, 4:59 PM

cjming added projects: Desktop Improvements (Vector 2022), Web-Team-Backlog.Jun 13 2022, 4:59 PM

cjming mentioned this in T309683: Turn off table of contents A/B test.

Jdlrobson updated the task description. (Show Details)Jun 13 2022, 5:43 PM

ovasileva triaged this task as Medium priority.Jun 14 2022, 3:28 PM

ovasileva updated the task description. (Show Details)

ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.

ovasileva added a parent task: T273473: [Epic] Improve the table of contents.

Jdlrobson moved this task from Incoming to Table of Contents on the Desktop Improvements (Vector 2022) board.Jun 15 2022, 2:32 PM

Jdlrobson moved this task from Current Fiscal Year to Not ready to estimate on the Web-Team-Backlog board.Jun 22 2022, 5:49 PM

Jdlrobson moved this task from Not ready to estimate to Kanbanana-FY-2021-22 on the Web-Team-Backlog board.Jun 22 2022, 6:10 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson updated the task description. (Show Details)Jun 24 2022, 7:47 PM

ovasileva moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 27 2022, 10:33 AM

ovasileva moved this task from Blocked on Others to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 28 2022, 5:27 PM

Jdlrobson set the point value for this task to 3.Jun 28 2022, 5:33 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming claimed this task.Jun 29 2022, 3:14 PM

cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 810404 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Remove Table of Contents feature flag

https://gerrit.wikimedia.org/r/810404

Change 810405 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/mediawiki-config@master] Remove Table of Contents config

https://gerrit.wikimedia.org/r/810405

cjming removed cjming as the assignee of this task.Jul 1 2022, 9:06 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson claimed this task.Jul 5 2022, 5:15 PM

Jdlrobson subscribed.

LGoto edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog (Kanbanana-FY-2021-22).Jul 5 2022, 5:52 PM

LGoto moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 6 2022, 2:33 AM

cjming claimed this task.Jul 6 2022, 2:27 PM

cjming moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 8 2022, 6:51 PM

hi @ovasileva quick Q re: TOC experiments -- is there a plan to re-run the A/B test?

In this mornings meeting we checked with @ovasileva that when we run the A/b test next we will do this for logged in users only. As part of this change, we will remove the link hijack JavaScript code and switch the bucketing from page ID to user ID.

cjming mentioned this in T313435: Refactor Table of Contents A/B test to bucket by user.Jul 20 2022, 6:46 PM

Per standup, moving this to code review (will break current A/B test - see T313435).

cjming updated the task description. (Show Details)Jul 20 2022, 7:00 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 20 2022, 8:55 PM

cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Jul 21 2022, 12:49 AM

Jdlrobson claimed this task.Jul 21 2022, 5:08 PM

Change 810404 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove Table of Contents feature flag

https://gerrit.wikimedia.org/r/810404

This can skip QA. I ran Pixel and saw no visual regressions introduced by this change so it's purely technical.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 21 2022, 9:00 PM

LGoto assigned this task to bwang.Jul 25 2022, 5:21 PM

Change 810405 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Table of Contents config

https://gerrit.wikimedia.org/r/810405

Mentioned in SAL (#wikimedia-operations) [2022-07-25T20:05:59Z] <cjming@deploy1002> Synchronized wmf-config: Config: [[gerrit:810405|Remove Table of Contents config (T310527)]] (duration: 03m 13s)

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2022, 8:30 PM

This looks done to me, great work @cjming !

bwang closed this task as Resolved.Jul 26 2022, 3:04 PM

bwang removed bwang as the assignee of this task.

bwang subscribed.

@bwang pointed out to me that this was incomplete. There is still code in ServiceWiring

		// Feature: T297610: Table of Contents
		// ================================
		$featureManager->registerRequirement(
			new OverridableConfigRequirement(
				$services->getMainConfig(),
				$context->getUser(),
				$context->getRequest(),
				null,
				Constants::CONFIG_TABLE_OF_CONTENTS,
				Constants::REQUIREMENT_TABLE_OF_CONTENTS,
				Constants::QUERY_PARAM_TABLE_OF_CONTENTS,
				null
			)
		);

		$featureManager->registerFeature(
			Constants::FEATURE_TABLE_OF_CONTENTS,
			[
				Constants::REQUIREMENT_FULLY_INITIALISED,
				Constants::REQUIREMENT_TABLE_OF_CONTENTS
			]
		);

Change 836274 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Update name of body class to avoid confusion

https://gerrit.wikimedia.org/r/836274

gerritbot added a project: Patch-For-Review.Sep 28 2022, 7:26 PM

Change 836274 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update name of body class to avoid confusion

https://gerrit.wikimedia.org/r/836274

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 29 2022, 3:00 PM

Jdlrobson closed this task as Resolved.Sep 29 2022, 3:03 PM

Jdlrobson claimed this task.

Remove Table of Contents feature flagClosed, ResolvedPublic3 Estimated Story PointsActions