Page MenuHomePhabricator
Create Task
Maniphest T310602

Unexpected back button behavior in VisualEditor's citation dialog
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Via T307188: Clean up feature flags except for new transclusion dialog sidebar we removed the $wgVisualEditorTransclusionDialogBackButton feature flag. Done in https://gerrit.wikimedia.org/r/804600. This made the new back button behavior the default, with no fallback to the old behavior. Unfortunately it looks like the Cite extension was still relying on the old behavior that is now removed. See https://gerrit.wikimedia.org/r/805368.

To do:

Details

SubjectRepoBranchLines +/-
Limit template dialog back button to 1 of 3 entry pointsmediawiki/extensions/VisualEditormaster+6 -10
Remove now unused back button-related feature flagmediawiki/extensions/Citemaster+0 -3
Remove $wgVisualEditorTransclusionDialogBackButton feature flagmediawiki/extensions/Citemaster+13 -3
Restore internal mechanism to use either back or close buttonmediawiki/extensions/VisualEditorwmf/1.39.0-wmf.16+9 -4
Restore internal mechanism to use either back or close buttonmediawiki/extensions/VisualEditormaster+9 -4
Remove $wgVisualEditorTransclusionDialogBackButton feature flagmediawiki/extensions/Citewmf/1.39.0-wmf.16+13 -3
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Jun 14 2022, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2022, 12:08 PM
thiemowmde moved this task from Backlog to Ready for story time on the WMDE-Templates-FocusArea board.Jun 14 2022, 12:08 PM
gerritbot added a comment.Jun 14 2022, 12:09 PM

Change 805368 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805368

gerritbot added a project: Patch-For-Review.Jun 14 2022, 12:09 PM
gerritbot added a comment.Jun 15 2022, 8:17 AM

Change 805748 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805748

gerritbot added a comment.Jun 15 2022, 8:39 AM

Change 805738 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805738

gerritbot added a comment.Jun 15 2022, 8:50 AM

Change 805748 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Decided to go with If68a822 instead.

https://gerrit.wikimedia.org/r/805748

gerritbot added a comment.Jun 15 2022, 9:09 AM

Change 805745 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.16] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805745

gerritbot added a comment.Jun 15 2022, 9:35 AM

Change 805738 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805738

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 15 2022, 10:00 AM
gerritbot added a comment.Jun 15 2022, 12:32 PM

Change 805801 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Limit template dialog back button to 1 of 3 entry points

https://gerrit.wikimedia.org/r/805801

gerritbot added a comment.Jun 15 2022, 12:34 PM

Change 805805 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove now unused back button-related feature flag

https://gerrit.wikimedia.org/r/805805

thiemowmde claimed this task.Jun 15 2022, 12:35 PM
thiemowmde set the point value for this task to 3.
thiemowmde moved this task from Ready for story time to In sprint on the WMDE-Templates-FocusArea board.
thiemowmde added projects: Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-06-08.
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.
gerritbot added a comment.Jun 15 2022, 1:21 PM

Change 805745 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.16] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805745

Stashbot added a comment.Jun 15 2022, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-15T13:38:17Z] <awight@deploy1002> Synchronized php-1.39.0-wmf.16/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js: Backport: [[gerrit:805745|Restore internal mechanism to use either back or close button (T310602)]] (duration: 00m 37s)

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 15 2022, 1:48 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.16; 2022-06-13); removed MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 15 2022, 2:00 PM
gerritbot added a comment.Jun 16 2022, 2:20 PM

Change 805368 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Replaced by If68a822 and potentially Id23d3ac.

https://gerrit.wikimedia.org/r/805368

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jun 16 2022, 3:29 PM
gerritbot added a comment.Jun 20 2022, 8:08 AM

Change 805801 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Limit template dialog back button to 1 of 3 entry points

https://gerrit.wikimedia.org/r/805801

gerritbot added a comment.Jun 20 2022, 8:09 AM

Change 805805 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove now unused back button-related feature flag

https://gerrit.wikimedia.org/r/805805

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.17; 2022-06-20); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 20 2022, 9:00 AM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 21 2022, 8:16 AM
thiemowmde closed this task as Resolved.Jun 22 2022, 8:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits