Page MenuHomePhabricator

Unexpected back button behavior in VisualEditor's citation dialog
Closed, ResolvedPublic3 Estimated Story Points

Description

Via T307188: Clean up feature flags except for new transclusion dialog sidebar we removed the $wgVisualEditorTransclusionDialogBackButton feature flag. Done in https://gerrit.wikimedia.org/r/804600. This made the new back button behavior the default, with no fallback to the old behavior. Unfortunately it looks like the Cite extension was still relying on the old behavior that is now removed. See https://gerrit.wikimedia.org/r/805368.

To do:

Event Timeline

Change 805368 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805368

Change 805748 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805748

Change 805738 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805738

Change 805748 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Decided to go with If68a822 instead.

https://gerrit.wikimedia.org/r/805748

Change 805745 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.16] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805745

Change 805738 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805738

Change 805801 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Limit template dialog back button to 1 of 3 entry points

https://gerrit.wikimedia.org/r/805801

Change 805805 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove now unused back button-related feature flag

https://gerrit.wikimedia.org/r/805805

Change 805745 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.16] Restore internal mechanism to use either back or close button

https://gerrit.wikimedia.org/r/805745

Mentioned in SAL (#wikimedia-operations) [2022-06-15T13:38:17Z] <awight@deploy1002> Synchronized php-1.39.0-wmf.16/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js: Backport: [[gerrit:805745|Restore internal mechanism to use either back or close button (T310602)]] (duration: 00m 37s)

Change 805368 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Replaced by If68a822 and potentially Id23d3ac.

https://gerrit.wikimedia.org/r/805368

Change 805801 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Limit template dialog back button to 1 of 3 entry points

https://gerrit.wikimedia.org/r/805801

Change 805805 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove now unused back button-related feature flag

https://gerrit.wikimedia.org/r/805805