| JTannerWMF | |
| Jun 16 2022, 2:37 PM |
| F35261608: Screenshot_20220621-161815_Wikipedia Dev.jpg | |
| Jun 21 2022, 11:22 PM |
| Restricted File | |
| Jun 21 2022, 1:35 PM |
| Restricted File | |
| Jun 21 2022, 12:58 PM |
| F35246893: Screenshot_20220608-174220(1).png | |
| Jun 16 2022, 2:37 PM |
Background
Our team made improvements to talk pages (See Epic) and added new entry points to access the article page and edit history that has made the about this article section of the talk page redundant. Furthermore, the about this article section looks out of place in dark mode when there is only one or two talk page messages.
Task
Remove about this article on the talk page
APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3470
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T291851 EPIC: Enhance Messaging Interface and Workflows for Android App | |||
| Resolved | cooltey | T310804 Remove about this article on talk page screen |
Hello,
I would like to take this as my first task for contribution.
Just for clarification, the task is to remove the section header in this screen with the title "About this talk page"?
Can I also remove the then unused localized string, or should I keep it?
{F35259939}
On my branch in the forked repository, the result looks now like this.
{F35260049}
Should I also remove the grey padding area above the view_talk_topics_footer?
Or should I even remove the whole view_talk_topics_footer view from the talk page?
Here is the pull request that I have created to solve the issue in the way I understand it.
https://github.com/wikimedia/apps-android-wikipedia/pull/3436
Thanks for submitting the PR, @TheElementNrOne!
Since the screenshots you have attached are not visible, here's the screenshot for you to check @JTannerWMF
Not sure should we keep the top padding on the footer or not.
Thank you @cooltey. I wonder why the screenshots are not visible to you.
I hope @JTannerWMF that I got the request for this task right, if not then I can adjust my pull request.
Hello sorry for the delay thank you for your work on this, it is deeply appreciated!
Sorry for not being clearer, so what I was thinking was removing:
The links to Edit History and View Article should remain in the overflow menu but not in this view as we see here.
Hello,
thank you for the reply. I think that I can work next week on these changes, as my schedule this week is very full.
Greetings!
Hi, @TheElementNrOne,
I'd like to take over the ticket for product schedule reasons if you don't have the bandwidth to handle this ticket. Please feel free to pick up another ticket in the Bug Backlog.
Please review the APK from the ticket description, thanks! I have to update the general background color to paper_color since we have to add additional bottom padding for the floating button in the view.
Looks good to me @cooltey.
@JTannerWMF please make sure to review this since you authored the task.
Thanks all.