Emails of thanks are not sent when 'enotifminoredits' is disabled
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	matej_suchanek
	Jun 19 2022, 2:56 PM

Description

'enotifminoredits' stands for "Email me also for minor edits of pages and files" and it is disabled by default.

EchoNotificationController::notify does the following:

includes/controller/NotificationController.php

foreach ( self::getUsersToNotifyForEvent( $event ) as $user ) {
	$userIds[$user->getId()] = $user->getId();
	$userNotifyTypes = $notifyTypes;
	// Respect the enotifminoredits preference
	// @todo should this be checked somewhere else?
	if (
		!$userOptionsLookup->getOption( $user, 'enotifminoredits' ) &&
		self::hasMinorRevision( $event )
	) {
		$userNotifyTypes = array_diff( $userNotifyTypes, [ 'email' ] );
	}

Ultimately, when you are thanked for a minor edit, have thanks sent to your email and have the option disabled, no email is sent to you.
It's somewhat weird and unexpected because the option is phrased as "Email me also for minor edits of pages and files", but thanks is not "an edit", it's a "thank you for an edit".

Original report: https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou_(technika)#Upozorn%C4%9Bn%C3%AD_na_pod%C4%9Bkov%C3%A1n%C3%AD

Event Timeline

matej_suchanek created this task.Jun 19 2022, 2:56 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 19 2022, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

1234qwer1234qwer4 subscribed.Jun 19 2022, 3:10 PM

Thanks for the bug report; the Growth team can't work on it any time soon.

In T310962#8024994, @kostajh wrote:

Thanks for the bug report; the Growth team can't work on it any time soon.

... although perhaps it is in the scope of the Growth-Positive-Reinforcement project; @RHo @KStoller-WMF what do you think?

matej_suchanek updated the task description. (Show Details)Jun 24 2022, 8:32 AM

In T310962#8024996, @kostajh wrote:

In T310962#8024994, @kostajh wrote:

Thanks for the bug report; the Growth team can't work on it any time soon.

... although perhaps it is in the scope of the Growth-Positive-Reinforcement project; @RHo @KStoller-WMF what do you think?

If it's a relatively small bug fix IMO this fits in well within Growth-Positive-Reinforcement as part of enabling newcomers to receive more praise, which would in theory be more likely to come from the minor edits they tend to make.

Emails of thanks are not sent when 'enotifminoredits' is disabledOpen, Needs TriagePublicActions

Description

Event Timeline

Emails of thanks are not sent when 'enotifminoredits' is disabled
Open, Needs TriagePublic
Actions