[regression] Communities and extensions should be able to mark up elements so they don't overlap the header
Open, HighPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Wed, Jun 22, 6:36 PM

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803941 we broke functionality that allowed extensions/gadgets to mark conntet in such a way it didn't overlap the header.

TODO

Restore the CSS
Improve the documentation so it's not accidentally removed again

https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header#My_templates_use_sticky_elements._How_do_I_get_them_to_work_with_the_sticky_header?

QA

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Sticky_test and login. Scroll the page until the "sticky element" text sticks. The sticky text should not overlap the sticky header

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+12 -14	Restore sticky header class and update TOC styles

Customize query in gerrit

Related Objects

Mentioned In: T311092: Sticky header conflicts with Structured Discussions sticky header on board pages

Event Timeline

Jdlrobson created this task.Wed, Jun 22, 6:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jun 22, 6:36 PM

Jdlrobson triaged this task as High priority.Wed, Jun 22, 6:36 PM

Jdlrobson mentioned this in T311092: Sticky header conflicts with Structured Discussions sticky header on board pages.

Change 807603 had a related patch set uploaded (by Jdlrobson; author: Clare Ming):

[mediawiki/skins/Vector@master] Restore sticky header class

https://gerrit.wikimedia.org/r/807603

gerritbot added a project: Patch-For-Review.Wed, Jun 22, 6:42 PM

Jdlrobson updated the task description. (Show Details)Wed, Jun 22, 6:45 PM

cjming moved this task from Upcoming to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.Wed, Jun 22, 7:37 PM

Jdlrobson assigned this task to Edtadros.Wed, Jun 22, 8:16 PM

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.

Change 807603 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restore sticky header class and update TOC styles

https://gerrit.wikimedia.org/r/807603

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Wed, Jun 22, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Wed, Jun 22, 9:30 PM

Jdlrobson renamed this task from [regression] Communities should be able to mark up elements so they don't overlap the header to [regression] Communities and extensions should be able to mark up elements so they don't overlap the header.Fri, Jun 24, 2:33 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Sticky_test and login. Scroll the page until the "sticky element" text sticks. The sticky text should not overlap the sticky header

Screen Recording 2022-06-25 at 7.16.49 PM.mov.gif (510×658 px, 1 MB)

	F35275879: Screen Recording 2022-06-25 at 7.16.49 PM.mov.gif
	Sun, Jun 26, 2:18 AM

[regression] Communities and extensions should be able to mark up elements so they don't overlap the headerOpen, HighPublic0 Estimated Story PointsActions