Page MenuHomePhabricator

[regression] Communities and extensions should be able to mark up elements so they don't overlap the header
Open, HighPublic0 Estimated Story Points

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803941 we broke functionality that allowed extensions/gadgets to mark conntet in such a way it didn't overlap the header.

TODO

  • Restore the CSS
  • Improve the documentation so it's not accidentally removed again

https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header#My_templates_use_sticky_elements._How_do_I_get_them_to_work_with_the_sticky_header?

QA

Event Timeline

Change 807603 had a related patch set uploaded (by Jdlrobson; author: Clare Ming):

[mediawiki/skins/Vector@master] Restore sticky header class

https://gerrit.wikimedia.org/r/807603

Jdlrobson set the point value for this task to 0.

Change 807603 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restore sticky header class and update TOC styles

https://gerrit.wikimedia.org/r/807603

Jdlrobson renamed this task from [regression] Communities should be able to mark up elements so they don't overlap the header to [regression] Communities and extensions should be able to mark up elements so they don't overlap the header.Fri, Jun 24, 2:33 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Sticky_test and login. Scroll the page until the "sticky element" text sticks. The sticky text should not overlap the sticky header

Screen Recording 2022-06-25 at 7.16.49 PM.mov.gif (510×658 px, 1 MB)