Page MenuHomePhabricator
Create Task
Maniphest T311170

[regression] Communities and extensions should be able to mark up elements so they don't overlap the header
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803941 we broke functionality that allowed extensions/gadgets to mark conntet in such a way it didn't overlap the header.

TODO

  • Restore the CSS
  • Improve the documentation so it's not accidentally removed again

https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header#My_templates_use_sticky_elements._How_do_I_get_them_to_work_with_the_sticky_header?

QA

QA Results - Beta

ACStatusDetails
1✅T311170#8027333

QA Results - Prod

ACStatusDetails
1✅T311170#8069470

Details

SubjectRepoBranchLines +/-
Restore sticky header class and update TOC stylesmediawiki/skins/Vectormaster+12 -14
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 22 2022, 6:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2022, 6:36 PM
Jdlrobson triaged this task as High priority.Jun 22 2022, 6:36 PM
Jdlrobson mentioned this in T311092: Sticky header conflicts with Structured Discussions sticky header on board pages.
gerritbot added a comment.Jun 22 2022, 6:42 PM

Change 807603 had a related patch set uploaded (by Jdlrobson; author: Clare Ming):

[mediawiki/skins/Vector@master] Restore sticky header class

https://gerrit.wikimedia.org/r/807603

gerritbot added a project: Patch-For-Review.Jun 22 2022, 6:42 PM
Jdlrobson updated the task description. (Show Details)Jun 22 2022, 6:45 PM
cjming moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 22 2022, 7:37 PM
Jdlrobson assigned this task to Edtadros.Jun 22 2022, 8:16 PM
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jun 22 2022, 8:34 PM

Change 807603 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restore sticky header class and update TOC styles

https://gerrit.wikimedia.org/r/807603

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 22 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 22 2022, 9:30 PM
Jdlrobson renamed this task from [regression] Communities should be able to mark up elements so they don't overlap the header to [regression] Communities and extensions should be able to mark up elements so they don't overlap the header.Jun 24 2022, 2:33 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 26 2022, 2:18 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Sticky_test and login. Scroll the page until the "sticky element" text sticks. The sticky text should not overlap the sticky header

Screen Recording 2022-06-25 at 7.16.49 PM.mov.gif (510×658 px, 1 MB)

Edtadros reassigned this task from Edtadros to ovasileva.Jul 11 2022, 1:51 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.org/wiki/User:EdTestCommons05 and login. Scroll the page until the "sticky element" text sticks. The sticky text should not overlap the sticky header

Screen Recording 2022-07-11 at 6.29.34 AM.mov.gif (428×956 px, 1 MB)

Edtadros updated the task description. (Show Details)Jul 11 2022, 1:53 PM
ovasileva closed this task as Resolved.Jul 13 2022, 8:35 AM

Looks good, resolving

Ciencia_Al_Poder mentioned this in T313187: StickyTableHeader (gadget) on English Wikipedia hidden behind top header in Vector Skin 2022.Jul 17 2022, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits