Page MenuHomePhabricator

New topic tool may insert an empty heading
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Visit a non-existing talk page and open the new topic form.
  2. Insert some text into the message field, but leave the title empty.
  3. Publish.

What happens?:
The topic is created with an empty heading (== ==). Example: link.

What should have happened instead?:
There is no heading after publishing with an empty title.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
MW: 1.39.0-wmf.17 (27d58b4)
DT: 0.0.0 (d5d896a)

Original report: https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou_(technika)#Nov%C3%A9_t%C3%A9ma_vkl%C3%A1d%C3%A1_pr%C3%A1zdn%C3%BD_nadpis

Event Timeline

I can reproduce. To be clear, this only happens non-existing talk pages. I am not convinced it's a regression, has anyone tried this in the past and has seen it working correctly?

It is actually a regression from T54747.

Change 809279 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix edit API adding empty section title when creating new pages

https://gerrit.wikimedia.org/r/809279

Change 809279 merged by jenkins-bot:

[mediawiki/core@master] Fix edit API adding empty section title when creating new pages

https://gerrit.wikimedia.org/r/809279

EAkinloose subscribed.

✅ There is no heading after publishing with an empty title.

Screenshot 2022-07-22 at 01.00.24.png (520×2 px, 101 KB)

For context, it looked like the screenshot below before fix
Screenshot 2022-07-22 at 01.00.42.png (744×3 px, 153 KB)