PHP 8.1: Implicit Conversion from float to int looses precision (hasOrMadeRecentPrimaryChanges callback)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	MarkAHershberger
	Jul 5 2022, 11:40 PM

Description

Seems like there should be an overall bug for this (see T311367, T307504 and T307284), but I ran into it again:

$ php tests/phpunit/phpunit.php '-c' 'tests/phpunit/suite.xml' --stop-on-failure --stop-on-error tests/phpunit/includes/db/LBFactoryTest.php
Using PHP 8.1.5
PHPUnit 8.5.27 #StandWithUkraine

....E

Time: 512 ms, Memory: 46.50 MB

There was 1 error:

1) LBFactoryTest::testChronologyProtector
Implicit conversion from float 1657063075.187724 to int loses precision

.../core/tests/phpunit/includes/db/LBFactoryTest.php:313
.../includes/libs/rdbms/ChronologyProtector.php:290
.../tests/phpunit/includes/db/LBFactoryTest.php:343
.../tests/phpunit/MediaWikiIntegrationTestCase.php:466
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
===

ERRORS!
Tests: 5, Assertions: 19, Errors: 1.

Details

Subject	Repo	Branch	Lines +/-
rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1	mediawiki/core	REL1_35	+16 -17
rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1	mediawiki/core	REL1_37	+16 -17
rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1	mediawiki/core	REL1_38	+16 -17
rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1	mediawiki/core	master	+11 -12

Customize query in gerrit

Related Objects

Mentioned Here: T307284: Deprecated: Implicit conversion from float 0.00029397010803222656 to int loses precision in .../includes/libs/rdbms/database/TransactionManager.php on line 236
T307504: Implicit conversion from float 1.2 to int loses precision
T311367: Implicit conversion from float 11.139 to int loses precision in APCUBagOStuff.php on line 91

Event Timeline

MarkAHershberger created this task.Jul 5 2022, 11:40 PM

Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptJul 5 2022, 11:40 PM

Change 811390 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/core@master] Adapt hasOrMadeRecentPrimaryChanges callback for 8.1

https://gerrit.wikimedia.org/r/811390

gerritbot added a project: Patch-For-Review.Jul 5 2022, 11:41 PM

Aklapper renamed this task from PHP 8.1: Implicit Conversion from float to int looses precision to PHP 8.1: Implicit Conversion from float to int looses precision (hasOrMadeRecentPrimaryChanges callback).Jul 6 2022, 6:25 AM

Aklapper added a project: MediaWiki-Core-Tests.

Krinkle claimed this task.Jul 6 2022, 7:26 PM

Krinkle edited projects, added MediaWiki-libs-Rdbms; removed MediaWiki-Core-Tests.

Restricted Application added a project: Performance-Team. · View Herald TranscriptJul 6 2022, 7:26 PM

Change 811390 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/811390

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2022, 8:30 PM

Krinkle closed this task as Resolved.Jul 6 2022, 11:31 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 4:01 AM

Change 814316 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_38] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/814316

gerritbot added a project: Patch-For-Review.Jul 16 2022, 11:27 AM

Change 814318 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_37] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/814318

Change 814319 had a related patch set uploaded (by Reedy; author: MarkAHershberger):

[mediawiki/core@REL1_35] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/814319

Change 814319 merged by jenkins-bot:

[mediawiki/core@REL1_35] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/814319

Change 814318 merged by jenkins-bot:

[mediawiki/core@REL1_37] rdbms: Adapt hasOrMadeRecentPrimaryChanges test mock for PHP 8.1

https://gerrit.wikimedia.org/r/814318

Change 814316 merged by jenkins-bot: