Page MenuHomePhabricator
Create Task
Maniphest T312311

'Change visibility' and 'Edit tags' buttons are not displayed in AMC page history
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To
• ERayfield
Authored By
Yahya
Jul 6 2022, 10:50 PM
Tags
Referenced Files
F35535039: Screen Shot 2022-09-26 at 11.52.38 AM.png
Sep 26 2022, 3:53 PM
F35534995: Screen Shot 2022-09-26 at 11.24.13 AM.png
Sep 26 2022, 3:25 PM
F35534809: image.png
Sep 26 2022, 2:35 PM
F35530492: patchdemo.wmflabs.org_wikis_7193243178_w_index.php_title=Main_Page&action=history(iPhone 12 Pro).png
Sep 23 2022, 8:38 AM
F35511226: image.png
Sep 6 2022, 6:21 PM
F35511229: image.png
Sep 6 2022, 6:21 PM
F35311729: en.m.wikipedia.org_w_index.php_title=San_Francisco&action=history(iPhone SE).png
Jul 8 2022, 9:11 AM
F35311722: Screenshot 2022-07-08 at 10.09.58.png
Jul 8 2022, 9:10 AM
View All 10 Files
Subscribers
Aklapper
• eigyan
Jdlrobson
jsn.sherman
Masumrezarock100
MdaNoman
Samwalton9-WMF
View All 9 Subscribers

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to bnwiki from a mobile device.
  • Enable AMC mode.
  • Go to the page history of any page.

What happens?:

Two buttons ('Change visibility of selected revisions' and 'Edit tags of selected revisions') are missing. These buttons should show below the 'Compare selected revisions' button.

Screenshot_20220707-043746~2.png (879×720 px, 112 KB)

What should have happened instead?:

These buttons should show like the screenshot below-

Screenshot_20220707-043839~2.png (1×720 px, 120 KB)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

SubjectRepoBranchLines +/-
adjusted button css layoumediawiki/skins/MinervaNeuemaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Yahya created this task.Jul 6 2022, 10:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2022, 10:50 PM
Yahya added a project: Bengali-Sites.Jul 6 2022, 10:52 PM
AntiCompositeNumber added a project: MinervaNeue.Jul 6 2022, 10:57 PM
TheresNoTime subscribed.Jul 6 2022, 11:31 PM
Jdlrobson added a project: Moderator-Tools-Team.Jul 7 2022, 11:53 PM
Jdlrobson added subscribers: jsn.sherman, Jdlrobson.

Hey @jsn.sherman could this relate at all to your recent changes?

jsn.sherman added a comment.Jul 8 2022, 12:03 AM
In T312311#8064025, @Jdlrobson wrote:

Hey @jsn.sherman could this relate at all to your recent changes?

The timing certainly lines up. I'll have a look and come back with a more conclusive answer tomorrow.

Samwalton9-WMF subscribed.Jul 8 2022, 9:00 AM
Samwalton9-WMF added a comment.EditedJul 8 2022, 9:10 AM

This is also true on English Wikipedia.

en.m.wikipedia.org_w_index.php_title=San_Francisco&action=history(iPhone SE).png (1×750 px, 188 KB)

Samwalton9-WMF attached a referenced file: F35311729: en.m.wikipedia.org_w_index.php_title=San_Francisco&action=history(iPhone SE).png. (Show Details)Jul 8 2022, 9:11 AM
Yahya added a comment.Jul 8 2022, 9:26 AM

I am also the administrator of Bengali Wikivoyage and test2wiki. The same problem there. I have received similar reports from administrators of other projects I know. I think this is happening everywhere except testwiki.

jsn.sherman closed this task as Resolved.Jul 8 2022, 2:57 PM
jsn.sherman claimed this task.

@Samwalton9 @Jdlrobson So far as I can tell, this wasn't moderator tools.

I verified that it wasn't

which was the most likely to impact this page. It was deployed last month, and I verified that reverting didn't impact the issue.

I locally walked back the two changes of ours that I did spot on this week's train (https://www.mediawiki.org/wiki/MediaWiki_1.39/wmf.19) with no impact:

jsn.sherman reopened this task as Open.Jul 8 2022, 2:57 PM

Undoing accidental status change

jsn.sherman added a comment.Jul 8 2022, 2:58 PM

Undoing accidental assignment. Apologies for the spam.

jsn.sherman removed jsn.sherman as the assignee of this task.Jul 8 2022, 2:58 PM
Jdlrobson added a comment.Jul 8 2022, 4:14 PM

It's being hidden because it's inside an element with class mw-history-revisionactions which is hidden.

That element has been hidden since 2019 by CSS (078aab76d8). It's markup as been stable in HTML since 2019 too (18871dc) so it looks like this is not a new regression. It doesn't look like it was included in the initial design pass (T219895).

What I'm a little confused about - was this recently working and got fixed? Did a gadget perhaps get disabled/changed?

Jdlrobson edited projects, added Web-Team-Backlog; removed Bengali-Sites.Jul 8 2022, 4:14 PM
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jul 8 2022, 6:11 PM
jsn.sherman added a comment.Jul 8 2022, 6:39 PM

You make a really good point: I'm not sure of the conditions in which those buttons are supposed to appear. If they were previously appearing in a clean mediawiki install, I think I've eliminated the changes we've made as the source of them disappearing. If some other dependency that I didn't have installed locally was causing them to appear, then my checks would have missed any problems that we introduced.

MdaNoman subscribed.Jul 11 2022, 1:42 PM
Samwalton9-WMF added a comment.Aug 1 2022, 11:35 AM

For future reference: to reproduce this issue I believe you need to be a user with the deleterevision and/or changetags user rights.

Samwalton9-WMF renamed this task from Missing two buttons in the page history of Bengali Wikipedia mobile site to 'Change visibility' and 'Edit tags' buttons are not displayed in AMC page history.Aug 1 2022, 11:35 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptAug 1 2022, 11:35 AM
Samwalton9-WMF set the point value for this task to 5.Aug 1 2022, 5:39 PM
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Samwalton9-WMF triaged this task as Medium priority.Aug 1 2022, 5:45 PM
• ERayfield claimed this task.Sep 1 2022, 4:26 PM
• ERayfield moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF added a comment.Sep 6 2022, 2:29 PM

We just did some digging to figure out how to test this problem locally. Simply having the deleterevision and changetags wasn't sufficient to see both buttons in the desktop interface.

Having the administrator user group provides users with deleterevision by default, so this enables the 'Change visibility...' button to display (in desktop view).

To see the 'Edit tags...' button, you need to both have the changetags user right (which users have by default) and also create a tag in Special:Tags. It should then start displaying.

This doesn't explain why it's hidden on mobile, but at least gets you into a position where you would expect the buttons to display.

• ERayfield added a comment.Sep 6 2022, 6:21 PM

To see the 'Edit tags...' button, you need to both have the changetags user right (which users have by default) and also create a tag in Special:Tags. It should then start displaying.
so, have it displaying, suggest that design take a look at it

image.png (564×1 px, 46 KB)

Also, there is these section of Select: All, None, Inverted that does not display on mobile, but does display on desktop - do they want that included also?

image.png (703×2 px, 80 KB)

• ERayfield added a comment.Sep 6 2022, 6:41 PM

I am going to have to go more in-depth into the logic of mediawiki\skins\MinervaNeue\skinStyles\mediawiki.action.history.styles.less, because it looks like the button should not show up until it is needed, so not displayed on default, just when conditions dictate that it is necessary to be available

gerritbot added a comment.Sep 8 2022, 2:40 PM

Change 830882 had a related patch set uploaded (by EllenR; author: EllenR):

[mediawiki/skins/MinervaNeue@master] WIP buttons are not displayed in AMC page history

https://gerrit.wikimedia.org/r/830882

gerritbot added a project: Patch-For-Review.Sep 8 2022, 2:40 PM
• ERayfield added a comment.Sep 8 2022, 2:55 PM

the first commit :
The committed section of code displays the Edit tags of selected revisions button, this button looks the same as the on the desktop version - TBH there is some logic about display of buttons on mobile, but many of the comments are no longer in the code. Am currently trying to find out about the logic, and also when the Change visibility button should be displayed - that button does not show up when desktop version is first loaded - so looking at the conditions necessary for the button to display.

Samwalton9-WMF added a comment.Sep 8 2022, 3:01 PM

this button looks the same as the on the desktop version

This is OK - the AMC history page is largely the same as the desktop site visually and if you look at the images in the task description this is how it was before it stopped showing up.

• ERayfield added a comment.Sep 16 2022, 6:12 PM

Notes from ticket
https://docs.google.com/document/d/1MjnjlOYz8uhKPAcTRaRz6K1nMW0CmXIfRNXyi5gZWjM/edit?usp=sharing

ovasileva moved this task from Not ready to estimate to Tracking on the Web-Team-Backlog board.Sep 19 2022, 8:56 AM
• ERayfield moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Sep 19 2022, 11:04 AM
PatchDemoBot added a comment.Sep 22 2022, 3:58 PM

Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7193243178/w

Samwalton9-WMF added a subscriber: • eigyan.Sep 23 2022, 8:38 AM

Thanks for the patch demo @eigyan!

I'm seeing 'Edit tags...' obscuring the top date header on history pages:

patchdemo.wmflabs.org_wikis_7193243178_w_index.php_title=Main_Page&action=history(iPhone 12 Pro).png (2×1 px, 262 KB)

• ERayfield added a comment.Sep 23 2022, 11:31 AM

Samwalton9 added a comment.Thu, Sep 8, 9:01 AM
this button looks the same as the on the desktop version

This is OK - the AMC history page is largely the same as the desktop site visually and if you look at the images in the task description this is how it was before it stopped showing up.

Once you said that, I figured I just needed to leave it alone - cause this page is UGLY

• eigyan added a comment.EditedSep 23 2022, 2:54 PM

Greetings @ERayfield and @Samwalton9, I saw the overlapping button behavior as well and noticed that if we remove the "float:right" and replace with "margin-bottom:12-14px" issue is resolved. I am unclear about the original need to float the element and am happy to discuss when we can.

• ERayfield added a comment.Sep 26 2022, 11:34 AM

@eigyan sounds like a plan!

• ERayfield added a comment.Sep 26 2022, 2:35 PM

Essex made some layout suggestions, which (as usual) were excellent - buttons still need help, but it looks better.

image.png (781×408 px, 46 KB)

PatchDemoBot added a comment.Sep 26 2022, 3:14 PM

Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/446ff22504/w

• eigyan added a comment.Sep 26 2022, 3:25 PM

LGTM on patchdemo @ERayfield

Screen Shot 2022-09-26 at 11.24.13 AM.png (1×932 px, 200 KB)

PatchDemoBot added a comment.Sep 26 2022, 3:50 PM

Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f536570349/w

• eigyan added a comment.Sep 26 2022, 3:53 PM

Also looks good @ERayfield on larger mobile viewports

Screen Shot 2022-09-26 at 11.52.38 AM.png (1×2 px, 233 KB)

PatchDemoBot added a comment.Sep 26 2022, 3:56 PM

Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7193243178/w/

PatchDemoBot added a comment.Sep 26 2022, 3:57 PM

Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/446ff22504/w/

PatchDemoBot added a comment.Sep 26 2022, 5:40 PM

Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/69d3e3c26b/w

gerritbot added a comment.Sep 26 2022, 6:52 PM

Change 830882 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] adjusted button css layou

https://gerrit.wikimedia.org/r/830882

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 26 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2022, 7:30 PM
Samwalton9-WMF added a comment.Sep 27 2022, 9:05 AM

Poked around with the Patch Demo and this is looking great :)

Samwalton9-WMF moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Sep 27 2022, 10:06 AM
Samwalton9-WMF closed this task as Resolved.Oct 4 2022, 1:44 PM

Tested in enwiki and looks good.

PatchDemoBot added a comment.Oct 20 2022, 4:11 PM

Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e378da4e18/w

PatchDemoBot added a comment.Oct 20 2022, 4:16 PM

Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/e378da4e18/w/

PatchDemoBot added a comment.May 15 2023, 5:49 PM

Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f536570349/w/

PatchDemoBot added a comment.May 15 2023, 5:50 PM

Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/69d3e3c26b/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL