Page MenuHomePhabricator

Regression: varied behaviors when clicking on "Add undocumented parameter"
Closed, ResolvedPublic0 Estimated Story Points

Assigned To
None
Authored By
awight
Jul 7 2022, 11:01 AM
Referenced Files
F35310612: image.png
Jul 7 2022, 11:01 AM
F35310610: image.png
Jul 7 2022, 11:01 AM
F35310606: image.png
Jul 7 2022, 11:01 AM
F35310608: image.png
Jul 7 2022, 11:01 AM
F35310604: image.png
Jul 7 2022, 11:01 AM

Description

We've found that the undocumented parameter section heading has different behaviors depending on what's focused at the moment before clicking. This is a bad sign, that we probably have two or more event handlers battling one another.

Scenario: a multiple-template transclusion dialog is open, and the "Add undocumented parameter" heading is visible,

image.png (244×549 px, 14 KB)

  1. Given that the content pane heading is collapsed and the heading is at the bottom of the screen and it is focused, when I click on the heading, then it expands and scrolls so the input is visible.

image.png (246×579 px, 30 KB)

  1. Given that the content pane heading is collapsed and the heading is at the bottom of the screen and it not focused, when I click on the heading, then it expands but doesn't scroll.

image.png (240×396 px, 13 KB)

  • The view should scroll as in (1).
  1. Given that the content pane heading is expanded and focus is on the heading or the input is visible on-screen, when I click on the heading then it collapses.

image.png (242×472 px, 14 KB)

  1. Given that the content pane heading is expanded but the template name input is off-screen and not focused, when I click on the heading then the input scrolls onto the screen but does not collapse.

image.png (237×521 px, 28 KB)

  • The section should collapse as in (3).

Event Timeline

awight triaged this task as Low priority.Jul 7 2022, 1:42 PM
awight updated the task description. (Show Details)

After discussing with @ECohen_WMDE, the ideal behavior is documented above, and we're leaving out of the sprint as a low-priority future cleanup. The only real concerning issue is that we might have multiple event handlers competing and possibly causing more confusing behavior in other circumstances.

WMDE-Fisch set the point value for this task to 0.Aug 3 2022, 7:44 AM