Page MenuHomePhabricator

If you double-sign a single message, then only the second part is highlighted
Open, Needs TriagePublic



  • Post normal comment (i.e., with one signature)
  • See comment highlighted in yellow on the page


  • Post comment containing two signatures, e.g.:
Hello.  ~~~~  
P.S.  Also this other thing.  ~~~~
  • See only the second comment highlighted in yellow on the page.

Event Timeline

It makes sense -- that'll get parsed as multiple comments, and the way the highlighter works is that it's passed the ID of the comment you replied to and it highlights the most-recent comment that's responding to it. Technically this doesn't even have to be your comment, though you'd need incredibly implausible timing to ever see someone else's comment highlighted.

We could probably fix this most-thoroughly by changing the DiscussionToolsEdit:addcomment API so it does a full parse of the new wikitext and returns any new comment IDs that're created, then change the highlighter so it would accept that. That's more expensive, though, and this is an incredibly niche problem.

Alternately, and cheaper, we could maybe alter the highlighter so it'll highlight the most recent comment and all other comments with the same timestamp?