We should document project-specific norms and guidelines related to code review processes. Some things to include:
- How we resolve conflicts/disagreements
- Timing of reviews: how quickly can people expect to get their code reviewed? How will we communicate about this?
- How we use the Gerrit number rating system: e.g. we use -1 to signal to each other that there are blocking issues that need to be resolved before merge, and that the person who applied the -1 should probably re-review once changes are made if time and availability allow for that
Acceptance criteria
- Write draft guidelines
- Review and finalize guidelines
- Figure out where to post them, then do so