Page MenuHomePhabricator

Parsoid should probably be calling a File's MediaTransformOutput->toHtml()
Open, MediumPublic

Description

Right now, Parsoid calls $env->getDataAccess()->getFileInfo() and then manually constructs the html for a file, for example AddMediaInfo::handleImage(). This means that it would need it a native implementation for all file types. This leads to problems like T305210 where the implementation is missing features.

The current code can probably stick around for the standalone version.

Event Timeline

Change 933177 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove attributes deprecated in TMH

https://gerrit.wikimedia.org/r/933177

Change 933177 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove attributes deprecated in TMH

https://gerrit.wikimedia.org/r/933177

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706