Page MenuHomePhabricator
Create Task
Maniphest T314088

Move MessageCache::get hook to a separate hook handler
Closed, ResolvedPublic
Actions

Description

Hooks that might be called early in the request lifecycle (MessageCache::get is invoked whenever a message is parsed) should avoid dependencies on other services as much as possible, to reduce the risk of dependency cycles. Hence, moving onMessageCache__get away from HomepageHooks which has a ton of dependencies.

Details

SubjectRepoBranchLines +/-
Remove MessageCache::get hook handler from HomepageHooksmediawiki/extensions/GrowthExperimentsmaster+0 -20
Move MessageCache::get hook to a separate hook handlermediawiki/extensions/GrowthExperimentsmaster+64 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh triaged this task as Medium priority.Jul 28 2022, 7:57 PM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2022, 7:57 PM
gerritbot added a comment.Jul 28 2022, 7:57 PM

Change 815687 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Move MessageCache::get hook to a separate hook handler

https://gerrit.wikimedia.org/r/815687

gerritbot added a project: Patch-For-Review.Jul 28 2022, 7:57 PM
kostajh assigned this task to Tgr.Jul 28 2022, 7:58 PM
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a parent task: T311850: [Epic] FY 2022-23 Growth Maintenance Work.
gerritbot added a comment.Jul 28 2022, 8:25 PM

Change 815687 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move MessageCache::get hook to a separate hook handler

https://gerrit.wikimedia.org/r/815687

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2022, 8:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 28 2022, 9:00 PM
Etonkovidova closed this task as Resolved.Aug 5 2022, 1:03 AM
gerritbot added a comment.Aug 23 2022, 4:30 AM

Change 825455 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Remove MessageCache::get hook handler from HomepageHooks

https://gerrit.wikimedia.org/r/825455

gerritbot added a project: Patch-For-Review.Aug 23 2022, 4:30 AM
Tgr reopened this task as Open.Aug 23 2022, 4:31 AM
Tgr moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Oops, I messed the patch a little.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 23 2022, 6:14 AM
gerritbot added a comment.Aug 23 2022, 6:33 AM

Change 825455 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove MessageCache::get hook handler from HomepageHooks

https://gerrit.wikimedia.org/r/825455

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.27; 2022-08-29); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 23 2022, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2022, 7:30 AM
Etonkovidova closed this task as Resolved.Sep 1 2022, 8:18 PM
sbassett mentioned this in T318262: Update StopForumSpam AbuseFilter hooks to use their own hook handler.Sep 21 2022, 6:03 PM
MShilova_WMF edited parent tasks, added: T320745: [Epic] Q1 FY 2022-23 Growth Maintenance Work; removed: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Oct 13 2022, 4:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits