Page MenuHomePhabricator
Create Task
Maniphest T314573

Link to latest comment fails when header contains mix of encodable text and plain percent encoding
Closed, ResolvedPublic
Actions

Description

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:ESanders_(WMF/encodebug
  2. Click on the timestamp after "Latest comment: "
  3. Observed: And error is show
  4. Expected: The comment is highlighted

Links to these comments in notifications work, so this is just a case of us not doing the proper escaping.

Details

SubjectRepoBranchLines +/-
Topic container latest comment link: Escape fragment for URLmediawiki/extensions/DiscussionToolsmaster+2 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Aug 4 2022, 1:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2022, 1:23 PM
gerritbot added a comment.Aug 4 2022, 1:33 PM

Change 820450 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Topic container latest comment link: Escape fragment for URL

https://gerrit.wikimedia.org/r/820450

gerritbot added a project: Patch-For-Review.Aug 4 2022, 1:33 PM
gerritbot added a comment.Aug 4 2022, 7:10 PM

Change 820450 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Topic container latest comment link: Escape fragment for URL

https://gerrit.wikimedia.org/r/820450

matmarex added a project: Editing-team (Kanban Board).Aug 4 2022, 7:10 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 7:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 8:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Aug 8 2022, 10:06 AM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 8 2022, 3:38 PM
VPuffetMichel moved this task from Backlog to Triaged on the DiscussionTools board.Aug 11 2022, 3:14 PM
ppelberg closed this task as Resolved.Aug 13 2022, 12:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits