Page MenuHomePhabricator
Create Task
Maniphest T314737

Unsaved changes dialog shows up twice on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Edit any page
  • Abandon your edit
  • Leave the page you were editing

What happens?: I am prompted twice: once when I abandon the edit and once when I leave the page I was editing

What should have happened instead?: I should only have been prompted when I abandon the edit

Other information (browser name/version, screenshots, etc.): Chrome for Android v104 on Android 12

T310737.jpg (1×1 px, 264 KB)

Details

SubjectRepoBranchLines +/-
Disallow using the `self` global variablemediawiki/extensions/MobileFrontendmaster+2 -1
EditorOverlayBase: Fix failing to clear warning about unsaved changesmediawiki/extensions/MobileFrontendmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Lomrjyo created this task.Aug 7 2022, 5:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2022, 5:55 PM
Lomrjyo renamed this task from Unsaved changes dialog shows up twice to Unsaved changes dialog shows up twice on mobile.Aug 7 2022, 6:03 PM
Lomrjyo updated the task description. (Show Details)Aug 7 2022, 6:40 PM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend (Editor)), Editing-team; removed MobileFrontend.Aug 8 2022, 7:54 AM
matmarex subscribed.Aug 8 2022, 9:48 PM

I can reproduce. The issue only occurs when using the wikitext editor.

First warning is an OOUI dialog:

image.png (2×3 px, 414 KB)

Second warning is a browser popup:

image.png (2×3 px, 1015 KB)

matmarex claimed this task.Aug 8 2022, 9:58 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.

Caused by rEMFR4dc6be17cf5e: Update contents of page dynamically after VE edit (T219420)

gerritbot added a comment.Aug 8 2022, 9:58 PM

Change 821315 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix undefined variable when disabling warning about unsaved changes

https://gerrit.wikimedia.org/r/821315

gerritbot added a project: Patch-For-Review.Aug 8 2022, 9:58 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Aug 8 2022, 9:58 PM
gerritbot added a comment.Aug 8 2022, 10:07 PM

Change 821316 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Disallow using the `self` global variable

https://gerrit.wikimedia.org/r/821316

gerritbot added a comment.Aug 10 2022, 6:59 AM

Change 821315 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix failing to clear warning about unsaved changes

https://gerrit.wikimedia.org/r/821315

gerritbot added a comment.Aug 10 2022, 6:59 AM

Change 821316 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Disallow using the `self` global variable

https://gerrit.wikimedia.org/r/821316

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2022, 7:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 10 2022, 8:00 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 10 2022, 4:32 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Aug 16 2022, 4:11 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Aug 18 2022, 12:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits