| Tchanders | |
| Aug 15 2022, 4:01 PM |
| F35697853: T315241_CheckUser_Chrome_FAIL.png | |
| Nov 2 2022, 6:19 PM |
| F35697855: T315241_CheckUser_IE11_Missing Pins.png | |
| Nov 2 2022, 6:19 PM |
| F35697851: T315241_CheckUser_Chrome_PASS.png | |
| Nov 2 2022, 6:19 PM |
| F35565096: T315241_CheckUser_IPColumnScrollTab_IE.png | |
| Oct 12 2022, 7:57 PM |
| F35565093: T315241_CheckUser_IPColumnScrollTab.png | |
| Oct 12 2022, 7:57 PM |
Since T261862, Special:Investigate uses an OO.ui.ButtonMenuSelectWidget with a custom menu with custom event handlers. Two new widgets were introduced in order to do this: InvestigateButtonMenuSelectWidget and InvestigateMenuSelectWidget
After T315240, we can remove InvestigateButtonMenuSelectWidget and pass the InvestigateMenuSelectWidget directly to an OO.ui.ButtonMenuSelectWidget instead.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove InvestigateButtonMenuSelectWidget | mediawiki/extensions/CheckUser | master | +4 -39 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • AGueyte | T315241 Remove InvestigateButtonMenuSelectWidget | |||
| Resolved | Tchanders | T315240 Allow custom menu to be passed in to OO.ui.ButtonMenuSelectWidget |
Change 824296 had a related patch set uploaded (by AGueyte; author: AGueyte):
[mediawiki/extensions/CheckUser@master] Remove InvestigateButtonMenuSelectWidget
The patch for this looks good. Moving this to blocked/stalled while we wait for the dependency to be pulled through via a new OOUI release - see T315240: Allow custom menu to be passed in to OO.ui.ButtonMenuSelectWidget
Change 824296 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Remove InvestigateButtonMenuSelectWidget
Testing note:
This patch doesn't change the feature but cleans up the code. A new custom menu is now allowed in the OOUI library which is passed in this patch.
In Special: Investigate, a custom menu should appear for each row in the IP column, you should be able to scroll down the menu with the down arrow but if clicking the tab, it should escape, as per the original request in T261862: CU 2.0: Cannot use tab to dismiss tools menu, submits instead
Hope this helps!
@AGueyte Custom menu does appear and I am able to scroll down on the menu with the down arrow, along with the tab escaping from the menu for Chrome and Firefox on Local.
On Internet Explorer though, I don't get the custom menu to appear as seen in the screenshot.
Chrome and Firefox
Internet Explorer
@AGueyte Custom menu does appear and I am able to scroll down on the menu with the down arrow, along with the tab escaping from the menu for Chrome and Firefox on Local.
On Internet Explorer though, I don't get the custom menu to appear as seen in the screenshot.
Chrome and Firefox
Internet Explorer
Hi George, do you use IE11 by any chance? Thanks :)
@AGueyte I was using IE11.
@AGueyte Custom menu does appear and I am able to scroll down on the menu with the down arrow, along with the tab escaping from the menu for Chrome and Firefox on Local.
On Internet Explorer though, I don't get the custom menu to appear as seen in the screenshot.
Chrome and Firefox
Internet Explorer
Hi George, do you use IE11 by any chance? Thanks :)
@AGueyte Custom menu does appear and I am able to scroll down on the menu with the down arrow, along with the tab escaping from the menu for Chrome and Firefox on Local.
On Internet Explorer though, I don't get the custom menu to appear as seen in the screenshot.
Chrome and Firefox
Internet Explorer
@GMikesell-WMF @dom_walden Is the menu also missing from IE11 before this patch was added? If so, we can file it as a separate bug.
@Tchanders Tested that the menus and pins were still missing before the patch (840ab08e22c93ef240506f8a73229461003ac716). Since this is before the patch, is it ok to move this task to Done and create another task for the IE11 issue?
IE11- missing menus on Username and IP
IE11- missing pins on IP and User agent
Chrome
menu
IE11- Missing menu and pins
@AGueyte Custom menu does appear and I am able to scroll down on the menu with the down arrow, along with the tab escaping from the menu for Chrome and Firefox on Local.
On Internet Explorer though, I don't get the custom menu to appear as seen in the screenshot.
Chrome and Firefox
Internet Explorer
@GMikesell-WMF @dom_walden Is the menu also missing from IE11 before this patch was added? If so, we can file it as a separate bug.
@GMikesell-WMF Thanks for taking a look!
Since this is before the patch, is it ok to move this task to Done and create another task for the IE11 issue?
Yes, sounds good to me! Would you be able to file that task, or can I help?
@Tchanders I created T322270 for the IE11 missing menus and pins. I will move this current task to Done. Thanks!