Page MenuHomePhabricator

Wrap Phonos output in data-nosnippet
Closed, ResolvedPublic2 Estimated Story Points

Description

Similar to T315259: Add data-nosnippet to the printfooter div, Phonos output might be used by Google in the SERP snippets — these are likely to render poorly, so should be wrapped in data-nosnippet

Event Timeline

Change 824038 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] PhonosButton: Wrap output in data-nosnippet

https://gerrit.wikimedia.org/r/824038

Change 824038 abandoned by Samtar:

[mediawiki/extensions/Phonos@master] PhonosButton: Wrap output in data-nosnippet

Reason:

https://gerrit.wikimedia.org/r/824038

Change 827150 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] PhonosButton: Wrap output in data-nosnippet

https://gerrit.wikimedia.org/r/827150

Testing notes

I don't think there is much we can do to test this. This changes the way Google will display {{#phonos}} output in the preview you see in its search results.

google_serp_preview.png (538×918 px, 77 KB)

Testing notes

I don't think there is much we can do to test this. This changes the way Google will display {{#phonos}} output in the preview you see in its search results.

Agreed — have moved to product sign-off :)

Change 827150 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] PhonosButton: Wrap output in data-nosnippet

https://gerrit.wikimedia.org/r/827150